fix: null values in schema enums in OpenAPI 3 examples#195
Merged
Conversation
Owner
|
LGTM. Thanks for your contribution! |
leeandher
added a commit
to getsentry/sentry
that referenced
this pull request
Apr 17, 2025
…t` (#88370) Relates to #88127, where most of the work was done. Upgrading `openapi-examples-validator` to 6.0.2 to include codekie/openapi-examples-validator#195 which will allow `null` values in example enums. Publishes the PUT method of the `OrganizationGroupIndexEndpoint`
andrewshie-sentry
pushed a commit
to getsentry/sentry
that referenced
this pull request
Apr 22, 2025
…t` (#88370) Relates to #88127, where most of the work was done. Upgrading `openapi-examples-validator` to 6.0.2 to include codekie/openapi-examples-validator#195 which will allow `null` values in example enums. Publishes the PUT method of the `OrganizationGroupIndexEndpoint`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tfranzel/drf-spectacular#235 (comment)
Having null in the enum is valid OpenAPI spec, but the examples validator currently fails if an example enum contains
nulland--no-additional-propertiesis set totrue.We implement a small fix, and a test for it.
our upstream PR that depends on this: getsentry/sentry#88370