Merged
Conversation
Implements comprehensive Rust type definitions for LangSmith annotation queues API. ## Types Implemented - QueueType - Enum for single vs pairwise queues - AnnotationQueue - Base queue schema - AnnotationQueueWithDetails - Queue with rubric details - AnnotationQueueRubricItem - Rubric evaluation criteria - CreateAnnotationQueueRequest - Queue creation payload - UpdateAnnotationQueueRequest - Queue update payload - ListAnnotationQueuesParams - Query parameters for listing - RunWithAnnotationQueueInfo - Run with queue metadata ## Implementation Details - All types derive Debug, Clone, Serialize, Deserialize - camelCase serialization for JSON API compatibility - Comprehensive doc comments with API references - 10 unit tests for serde roundtrip validation - Module exported in sdk/src/lib.rs with re-exports Follows patterns from sdk/src/runs.rs and matches OpenAPI schemas. Fixes #337 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements comprehensive Rust type definitions for the LangSmith annotation queues API, providing Phase 1 of annotation queue support.
- Adds complete type definitions for annotation queues including request/response types and query parameters
- Implements serde serialization with proper camelCase naming for API compatibility
- Includes 10 unit tests validating serialization/deserialization roundtrip behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/src/annotation_queues.rs | New module with complete type definitions for annotation queues API including QueueType enum, request/response structs, and comprehensive unit tests |
| sdk/src/lib.rs | Exports new annotation_queues module and re-exports commonly used types for ergonomic imports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements comprehensive Rust type definitions for LangSmith annotation queues API (Phase 1 of #334).
Changes
New Types in
sdk/src/annotation_queues.rsModule Integration
sdk/src/lib.rsImplementation Details
Debug,Clone,Serialize,Deserialize#[serde(skip_serializing_if = "Option::is_none")]sdk/src/runs.rsreference/api-specs/annotation-queue-schemas.jsonRelated Issues
Fixes #337
Parent: #334
Test Plan
cargo check --workspace --all-featurespassescargo clippy --package langstar-sdk -- -D warningspassescargo test --package langstar-sdk --lib annotation_queues::testspassescargo fmt --checkpassesFiles Changed
sdk/src/annotation_queues.rs- New file (512 lines)sdk/src/lib.rs- Module export and re-exports🤖 Generated with Claude Code