C2LC-688: Add the new Music Band background#412
Merged
sbates-idrc merged 7 commits intocodelearncreate:develop-1.8from Jun 27, 2023
Merged
C2LC-688: Add the new Music Band background#412sbates-idrc merged 7 commits intocodelearncreate:develop-1.8from
sbates-idrc merged 7 commits intocodelearncreate:develop-1.8from
Conversation
Still to do: * Cell descriptions * Description for the background (MusicBand.label) * Thumbnail hover styling
* Reduce the number of strings on the guitar and change the angle of the neck to 45 degrees, to remove rendering artifacts * Change the colour of the top and sides of the grayscale and high contrast versions so that they don't blend into the Weavly UI
Adjust the size and colour of the background behind the stage to increase the visibility of the drawing line.
Contributor
|
Thanks for the great work @sbates-idrc, everything's working great with the changes in this PR. However, I found an issue from before, which is that border colour for ProgramBlockEditor__character-column-character-container class is not set for grayscale and high-contrast themes, so it is using default colour, which doesn't seem right for the two themes. Probably makes sense to address the issue in another PR, maybe after 1.8 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.