Add ProgramBlockCache and new ProgramBlock types#541
Merged
sbates-idrc merged 2 commits intocodelearncreate:develop-1.13from Sep 27, 2024
Merged
Add ProgramBlockCache and new ProgramBlock types#541sbates-idrc merged 2 commits intocodelearncreate:develop-1.13from
sbates-idrc merged 2 commits intocodelearncreate:develop-1.13from
Conversation
* Replace the Map used for the program block cache with a new ProgramBlockCache class, with typed accessors for the loop label and position * Add new separate program block types for: MovementProgramBlock, StartLoopProgramBlock, and EndLoopProgramBlock
chosww
approved these changes
Sep 26, 2024
Contributor
chosww
left a comment
chosww
left a comment
There was a problem hiding this comment.
Thanks @sbates-idrc, the changes look good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the Map used for the program block cache with a new
ProgramBlockCacheclass, with typed accessors for the loop label and positionAdd new separate program block types for:
MovementProgramBlock,StartLoopProgramBlock, andEndLoopProgramBlock