fix: Activity timeline for company and deal entities#49
Merged
Conversation
…e2e tests - Add DealActivitiesController with GET timeline and POST comment routes - Register DealActivitiesController in SalesModule - Fix company entity pluralization bug (companys → companies) in frontend API client - Expand DealDetailPage with full activity helper methods - Uncomment and enable previously skipped deal activity timeline tests - Add deal-activities.spec.ts with full timeline e2e test suite Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
anujeet98
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Activity timeline for company and deal entities
Problem
Company and deal activity timelines were returning 404 errors:
"company"as"companys"instead of"companies", so requests hit a non-existent route.DealActivitiesControllerwas never implemented, soGET /deals/:id/activitiesandPOST /deals/:id/activities/commentsdidn't exist.Contact activities were unaffected as
"contact"→"contacts"is a regular plural.Changes
Backend
DealActivitiesControllerwithGET /deals/:dealId/activitiesandPOST /deals/:dealId/activities/commentsroutesDealActivitiesControllerinSalesModuleFrontend
activities.ts:company → companies(wascompanys)E2E Tests
DealDetailPagewith full activity helper methods (createComment,editComment,cancelEditComment,isPostButtonDisabled,hasNoActivityMessage, etc.)deals.spec.tsdeal-activities.spec.tswith a full timeline test suiteTest Plan
bun e2e— all deal activity tests passRoot Cause
companys