Replace skip with persisted other option for architecture#20
Merged
Conversation
- Add "other" option to architecture facet with empty recipe, so selecting it applies no conventions but persists the choice - Keep architecture as required: false; update promptSelect to skip adding the generic "Skip" button when a facet already has an "other" option — avoiding a redundant skip+other pair in the UI - Update all integration tests to select "other" instead of "__skip__" for architecture, and adjust assertions to expect architecture: "other" in persisted choices https://claude.ai/code/session_01QEdCvpUop37cdbqgiVzkqr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
selecting it applies no conventions but persists the choice
adding the generic "Skip" button when a facet already has an "other"
option — avoiding a redundant skip+other pair in the UI
for architecture, and adjust assertions to expect architecture: "other"
in persisted choices
https://claude.ai/code/session_01QEdCvpUop37cdbqgiVzkqr