fix(beads): robustly insert phase-id placeholders in plan files#254
Open
fix(beads): robustly insert phase-id placeholders in plan files#254
Conversation
The previous handleAfterPlanFileCreated relied on two narrow regex patterns that matched the exact task-section text produced by PlanManager. This broke whenever the plan file had been modified by the LLM (e.g. entrance-criteria sections added) or was created by a different template – so no <!-- beads-phase-id: TBD --> placeholder was ever inserted. updatePlanFileWithPhaseTaskIds then found nothing to replace, leaving extractPhaseTaskIdFromPlanFile unable to return a task ID, and the instructions showed the literal <phase-task-id> placeholder text. Replace the regex approach with a line-by-line scan that uses the state machine's phase list to identify which ## headings are workflow phases and injects the TBD placeholder immediately after each one – unless a beads-phase-id comment is already present on the next line. This is robust against any plan file content. Also expand the behavioral test suite with three new cases (B2-B4) covering fresh plan files, idempotent behaviour, and LLM-modified files with entrance criteria. https://claude.ai/code/session_01MyfZvrv4Cfk4icMKE7i5Wz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous handleAfterPlanFileCreated relied on two narrow regex
patterns that matched the exact task-section text produced by
PlanManager. This broke whenever the plan file had been modified by
the LLM (e.g. entrance-criteria sections added) or was created by a
different template – so no placeholder
was ever inserted. updatePlanFileWithPhaseTaskIds then found nothing
to replace, leaving extractPhaseTaskIdFromPlanFile unable to return
a task ID, and the instructions showed the literal
placeholder text.
Replace the regex approach with a line-by-line scan that uses the
state machine's phase list to identify which ## headings are workflow
phases and injects the TBD placeholder immediately after each one –
unless a beads-phase-id comment is already present on the next line.
This is robust against any plan file content.
Also expand the behavioral test suite with three new cases (B2-B4)
covering fresh plan files, idempotent behaviour, and LLM-modified
files with entrance criteria.
https://claude.ai/code/session_01MyfZvrv4Cfk4icMKE7i5Wz