add timeout to the call that gets first EngineIOPacket in XHRTranspor… #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tConnection.handle() and set version to 1.0.2-b
alexsaveliev
added a commit
that referenced
this pull request
Jan 5, 2018
- add timeout to the call that gets first `EngineIOPacket` in `XHRTransportConnection.handle()` - re-applying #10 after branch rename
|
I renamed a branch so your PR was closed, sorry. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tConnection.handle() and set version to 1.0.2-b
basically replaced take() with poll() with timeout. I think 3 min is excessive, but leave it up to you to decide. I do not have a clear understanding of how do we end up in the situation where the client has already closed connection by the time of the call to take() is made, so the socket is in CLOSE_WAIT state and take() never returns. See my emails for more detailed analysis.