Open
Conversation
nanafox
requested changes
Dec 4, 2023
Collaborator
There was a problem hiding this comment.
Hello @lawalalx, I have a few questions and concerns...
- Does your code follow the Betty style?
- The headers you have here are defined in our header file
liteshell.h. - Where is
MAX_PATHdefined? - Finally, I see you are handling errors which is fine but is that how
shhandles the errors? - What error codes are we receiving on such errors?
- Looks like your function documentation is not complete as well
Collaborator
There was a problem hiding this comment.
@lawalalx what's your current progress on this?
Collaborator
Author
There was a problem hiding this comment.
I will reply to every quest and make necessary corrections before the close of biz today. currently tightly engaged
Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.