Skip to content

Fixed Fold Marker click not changing folding gutter marker status.#1679

Closed
parisk wants to merge 1 commit intocodemirror:masterfrom
parisk:foldmarker_click_fix
Closed

Fixed Fold Marker click not changing folding gutter marker status.#1679
parisk wants to merge 1 commit intocodemirror:masterfrom
parisk:foldmarker_click_fix

Conversation

@parisk
Copy link
Copy Markdown
Contributor

@parisk parisk commented Jul 15, 2013

Fix for the issue "Clicking CodeMirror-foldmarker does not toggle CodeMirror-foldgutter-folded".

@0b10011
Copy link
Copy Markdown
Contributor

0b10011 commented Jul 15, 2013

Hey @parisk, just wanted to let you know that on GitHub, you can reference issues by typing # followed by either the issue number (e.g. #1678) or you can select it from a dropdown list by beginning to type the issue's title without spaces (e.g. type #clickingcodemirror and click the corresponding issue).

And just so it gets pulled into this discussion: #1678.

@parisk
Copy link
Copy Markdown
Contributor Author

parisk commented Jul 15, 2013

Great. Good to know about that. Thanks.

Paris

2013/7/15 Brandon Frohs notifications@github.com

Hey @parisk https://github.com/ParisK, just wanted to let you know that
on GitHub, you can reference issues by typing # followed by either the
issue number (e.g. #1678) or you can select it from a dropdown list by
beginning to type the issue's title without spaces (e.g. type
#clickingcodemirror and click the corresponding issue).

And just so it gets pulled into this discussion: #1678#1678
.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1679#issuecomment-20997307
.

marijnh added a commit that referenced this pull request Jul 25, 2013
Also adds parameters to a range's clear event.

Issue #1678
Issue #1679
@marijnh
Copy link
Copy Markdown
Member

marijnh commented Jul 25, 2013

Thanks. I've pushed the attached patch instead, which also fixes the case where a range is unfolded by moving the cursor into it.

@marijnh marijnh closed this Jul 25, 2013
anaran pushed a commit to anaran/CodeMirror that referenced this pull request Feb 22, 2014
Also adds parameters to a range's clear event.

Issue codemirror#1678
Issue codemirror#1679
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants