rst mode: assertion error in rst-role handling...

[maxodoble]

the role handling in rst mode crashes codemirror (assertion error undefined).

just try to enter something like "bla bla :math: bla bla" in codemirror when rst mode is active.

• codemirror stops working, right after you enter the second ":"

opening a file, when a rst role is slightly wrong typed or has a mistyped character (see "x"), crashes codemirror.

example:
:ref:xparameterstudy

or try to copy/paste the above string into the editor: codemirror crashes.

[marijnh]

Are you sure you're working with the current code? I can not reproduce any problems with either of those strings in http://codemirror.net/mode/rst/

[maxodoble]

Hello,

i am using latest codemirror and you can reproduce it also with your webpage version:
just try to copy and paste the following string into the editor (somewhere inside the existing text) at your webpage: http://codemirror.net/mode/rst/index.html

Teststring: (sorry, i forgot to quoute the backticks in my first posting!):
:ref:xtest

the "bla bla :math: bla" problem is harder to trigger, but i stumbled upon this more than once.

[marijnh]

The rst mode seems to have been doing something rather misguided -- it checked whether the syntax conformed to what it expected, and threw an exception when it didn't. That isn't a very good idea for a syntax highlighter. I've removed the exception-throwing mechanism in the attached patch.

The mode's code, which I never really closely reviewed, seems rather confused on other points as well, so don't be surprised if it behaves oddly. But now at least it should no longer crash your editor.