Skip to content
This repository was archived by the owner on Apr 16, 2026. It is now read-only.

Creation of formula (spreadsheet) mode#2976

Closed
robertleeplummerjr wants to merge 3 commits intocodemirror:masterfrom
Spreadsheets:master
Closed

Creation of formula (spreadsheet) mode#2976
robertleeplummerjr wants to merge 3 commits intocodemirror:masterfrom
Spreadsheets:master

Conversation

@robertleeplummerjr
Copy link
Copy Markdown
Contributor

No description provided.

@marijnh
Copy link
Copy Markdown
Member

marijnh commented Dec 11, 2014

Could you tell me a bit more about what language this is? Does it implement the format used by a specific (set of) spreadsheet software?

@robertleeplummerjr
Copy link
Copy Markdown
Contributor Author

This language is the same used by Excel, Google Sheets, OpenOffice, LibreOffice, and jQuery.sheet.

Comment thread mode/formula/formula.js Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use two spaces, not tabs, for indentation.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@marijnh
Copy link
Copy Markdown
Member

marijnh commented Dec 11, 2014

Is the word 'formula' a commonly used term for this language? If not, would it be okay to rename this mode to 'spreadsheet'?

@robertleeplummerjr
Copy link
Copy Markdown
Contributor Author

Yes. I will take care of all of these requests. Thanks for being as
thorough as you are Marijn, you are an awesome developer.

On Thu, Dec 11, 2014 at 11:17 AM, Marijn Haverbeke <notifications@github.com

wrote:

Is the word 'formula' a commonly used term for this language? If not,
would it be okay to rename this mode to 'spreadsheet'?


Reply to this email directly or view it on GitHub
#2976 (comment)
.

Robert Plummer

@robertleeplummerjr
Copy link
Copy Markdown
Contributor Author

Renamed to spreadsheet.

marijnh added a commit that referenced this pull request Dec 12, 2014
@marijnh
Copy link
Copy Markdown
Member

marijnh commented Dec 12, 2014

Thanks. Merged as 63e0eff, and tweaked a bit in eb8f15c.

You still had tabs and 4-space indentation all over the place, by the way.

The idea here was to find a number followed by letters or underscore, which is never acceptable. I don't believe changing this to \w+ would allow for that.

You've just matched all digits. If more word characters follow, that means the first of those is not a digit, and thus /\w+/ does detect the error case you are interested in.

@marijnh marijnh closed this Dec 12, 2014
@robertleeplummerjr
Copy link
Copy Markdown
Contributor Author

You sir are "the man".

On 5:01AM, Fri, Dec 12, 2014 Marijn Haverbeke notifications@github.com
wrote:

Closed #2976 #2976.


Reply to this email directly or view it on GitHub
#2976 (comment).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants