Matched bracket outline sometimes hides the caret

[ethanPlumbly]

Describe the issue

The outline of a matching bracket highlight in the one-dark theme sometimes covers the caret making it no longer visible.

https://github.com/codemirror/theme-one-dark/blob/main/src/one-dark.ts#L76

Have had to make a theme extension that overwrites the outline to 0px to effectively remove it so the caret can always be seen.

This is also slightly effected by zooming in and out of the page so some zoom levels have the caret visible in a certain position, some do not.

Caret is to the right of the left bracket (and not blinking) but not visible:

After creating an extension that removes the highlight outline:

Browser and platform

Chromium

Reproduction link

No response

[marijnh]

Is this with or without the drawSelection extension?

[ethanPlumbly]

Without. Here is the list I am using:

• python(),
• indentUnit.of(" "),
• oneDark
• lineNumbers(),
• highlightSpecialChars(),
• history(),
• indentOnInput(),
• bracketMatching(),
• codeFolding(),
• foldGutter(),
• closeBrackets(),
• EditorState.allowMultipleSelections.of(true),
• rectangularSelection(),
• highlightActiveLine(),
• keymap.of(...)
• EditorState.readOnly.of(...)
• EditorView.editable.of(...)
• EditorView.updateListener.of(...)

Hope this helps! :)

[marijnh]

Indeed, for some reason Chrome seems to draw outlines over the native cursor. I'd generally advise using drawSelection to avoid this and a bunch of other native cursor bugs, but attached patch removes these outlines.

[ethanPlumbly]

Amazing, thank you so much!