Skip to content
This repository was archived by the owner on Apr 15, 2026. It is now read-only.

feat(export): Allow Exporting Complete Functions#2

Closed
mjantscher wants to merge 1 commit intocodemirror:mainfrom
mjantscher:chore/export
Closed

feat(export): Allow Exporting Complete Functions#2
mjantscher wants to merge 1 commit intocodemirror:mainfrom
mjantscher:chore/export

Conversation

@mjantscher
Copy link
Copy Markdown

I'm looking to dynamically add config schema to the autocomplete.

I want to be able to know when a user has typed a "parent" as defined by the sourceContext method so that I can then make an api call before populating the schema table with the columns returned from the api.

I should be able to do that with easy access to the methods that are written in complete.ts

@marijnh
Copy link
Copy Markdown
Member

marijnh commented Sep 29, 2021

I recommend you duplicate the logic required for this instead—it's not a lot, and I dislike exporting internals like this since it requires me to document them and lock them down forever.

@marijnh marijnh closed this Sep 29, 2021
@mjantscher mjantscher deleted the chore/export branch September 30, 2021 14:36
@mjantscher
Copy link
Copy Markdown
Author

@marijnh that works for me. I noticed that after upgrading to versions 0.19.x that the "schema" mapping no longer seems to work. It looks like the '.' is no longer being identified (resolveInner returns it as a Script) so that the parent is not matched. Is that something you see as well?

@marijnh
Copy link
Copy Markdown
Member

marijnh commented Oct 8, 2021

Seems to still work for me. Can you show how you're setting up your editor and what you're doing precisely?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants