fix(codemods/react/19/remove-legacy-context): improve and fix issues in remove-legacy-context codemod#42
Merged
amirabbas-gh merged 5 commits intomainfrom Feb 7, 2025
Conversation
…19/remove-legacy-context
mohebifar
approved these changes
Jan 21, 2025
Comment on lines
+24
to
+26
| "dependencies": { | ||
| "@codemod/utils": "^1.1.0" | ||
| } |
Member
There was a problem hiding this comment.
This is not used and should be removed
mohebifar
approved these changes
Jan 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Description
This PR fixes multiple issues related to the
remove-legacy-contextcodemod in thereact/19directory. The following changes were made:Fix the main codemod logic: Resolved functional issues in the
remove-legacy-contextcodemod to ensure accurate transformation.Fix test fixtures: Corrected and updated test fixtures to align with the codemod's expected behavior.
Handle null cases in
findPatterns: Fixed a bug wherefindPatternscould return null, causing runtime errors during execution.Correct package address: Updated the
@codemod.com/codemod-utilspackage address to the correct location inremove-legacy-context.🧪 Test Plan
remove-legacy-contextcodemod:npm test