Docs/revamp and v0.9.0#1
Conversation
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (1 file)
Fix these issues in Kilo Cloud Previous Review Summaries (2 snapshots, latest commit 4fa0e62)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 4fa0e62)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
Files Reviewed (2 files)
Fix these issues in Kilo Cloud Previous review (commit 0feab19)Status: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Resolved Issues
Reviewed by deepseek-v4-pro · Input: 40.5K · Output: 6.2K · Cached: 254.9K |
- Migration: Add concurrent index on content_hash, update GIN indexes to use CONCURRENTLY. - Tests: Replace silent returns with pytest.skip. - Store: Replace stdout debug print with logger.debug. - Entrypoint: Dynamically query and set enable_indexscan on active database. - Tools: Wrap top_k, min_similarity, etc. cast operations in try/except ValueErrors. - WeakRegistry: Track AsyncWriter instances via WeakSet to avoid expensive gc.get_objects. - EntityExtractor: Narrow docker_image & hostname regexes; use span-based URL deduplication to avoid dropping standalone substring matches. - Webhook: Wrap thread runner in try/except Exception to prevent silent thread crashes. - Indentation: Fix 9-space indentation in server.py. - Compose: Use HEXUS_DB_PASS env var instead of hardcoded postgres password. - Pyproject: Remove stale TODO comment. - Embedder: Set default USER env var to prevent pwd.getpwuid KeyError in custom UIDs.
…ent index creation in psycopg
…parsing errors with semicolons in comments
…docker_image pattern
|
|
||
| release-pypi: | ||
| needs: [lint, build-and-test] | ||
| if: github.event_name == 'push' && github.ref == 'refs/heads/main' |
There was a problem hiding this comment.
CRITICAL: PyPI publish on every push to main will fail after first release
The release-pypi job was changed from tag-triggered (startsWith(github.ref, 'refs/tags/v')) to main-branch-triggered (github.ref == 'refs/heads/main'). Every push to main will attempt to publish to PyPI, but the version in pyproject.toml (currently 0.9.0) won't change between pushes, causing PyPI to reject duplicate version uploads with "File already exists". This will make CI appear broken on every subsequent merge to main. Revert to tag-based publishing or add automatic version management (e.g., setuptools-scm).
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
| run: | | ||
| TAG_NAME=${{ github.ref_name }} | ||
| # Check if the main branch contains the tag's commit | ||
| if git branch -r --contains "tags/$TAG_NAME" | grep -q "origin/main"; then |
There was a problem hiding this comment.
WARNING: Tag verification uses substring grep match that could produce false positives
The current check grep -q "origin/main" will match any branch name containing origin/main as a substring, such as origin/main-backup or origin/maintenance. If a tag exists on such a branch but not on origin/main, the check would incorrectly pass. Use git merge-base --is-ancestor for an exact ancestor check that is immune to substring mismatches.
| if git branch -r --contains "tags/$TAG_NAME" | grep -q "origin/main"; then | |
| if git merge-base --is-ancestor "tags/$TAG_NAME" origin/main; then |
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
🚀 Hexus v0.9.0 - The Documentation & Polish Update
This PR delivers a massive overhaul to the repository structure and
documentation, officially bumping the version to 0.9.0 as we gear up for a
major 1.0 release!
What's inside:
• 📝 README Overhaul: Completely revamped the main README.md to be punchy,
engaging, and focused on the high-level value (sub-millisecond benchmarks, no-
LLM speed, multi-agent isolation).
• 🧹 Deep Clean: Moved all heavy technical documentation (hooks, schemas, DB
configurations) out of the main page and into a dedicated
docs/TECHNICAL_DETAILS.md file.
• 📂 Consolidated Docs: Moved historical planning docs and benchmarks into the
docs/ and benchmarks/ directories to keep the root repository pristine.
Merged ROADMAP.md and UPCOMING.md into a single cohesive roadmap.
• 🛠️m Developer Quality of Life: Added a new root Makefile to simplify common
commands (e.g., make test , make docker-up ).
• ⚖️ License Attribution: Updated the LICENSE and README footer to attribute
Hexus Contributors to properly reflect the massive amounts of new
functionality added to the codebase.
• 🎨 Status Badges: Added GitHub Actions CI and PyPI badges directly to the
README.
Notes for Reviewers:
The main branch should now be protected with PR approvals and CI status
checks required before merging. This PR sets the stage for a clean,
professional, and easily consumable 1.0 release.