getShortWeekdays() in DateFormatSymbols localize the localized 'long week names'

Original issue 1244 created by codenameone on 2014-12-28T17:51:14.000Z:

What steps will reproduce the problem?

1. Add translated (not English) weeks to the resource bundle (localization) like this: WEEKDAY_LONGNAME_MONDAY and and short weekdays like this: WEEKDAY_SHORTNAME_MONDAY
2. Use DateFormatSymbols to use the localized weeks with SimpleDateFormat:
   dateFormatSymbols.setResourceBundle(UIManager.getInstance().getResourceBundle());
   simpleDateFormat.setDateFormatSymbols(dateFormatSymbols);
3. Choose a format (for SimpleDateFormat) with short names of the weekdays.

What is the expected output? What do you see instead?
In my case: The long name is 'maandag' and the short name is 'ma'. I expect to see 'ma' when localizing they weekday. Instead, I see 'maa' (the first three characters of the weekday longname).

What version of the product are you using? On what operating system?
CN1 revision 1972. Linux, Netbeans 8, latest plugin.

Please provide any additional information below.

I think I found in the source what the problem is:

166 public String[] getShortWeekdays() {
167 synchronized (this) {
168 if (shortWeekdays == null) {
169 shortWeekdays = createShortforms(getWeekdays(), L10N_WEEKDAY_SHORTNAME);
170 }
171 }
172 return shortWeekdays;
173 }

I think on line 169, getWeekdays() should be WEEKDAYS.
Because now the localized weekdays are returned. I think it should be just like in getShortMonths():

public String[] getShortMonths() {
    synchronized (this) {
        if (shortMonths == null) {
            shortMonths = createShortforms(MONTHS, L10N_MONTH_SHORTNAME);
        }
    }
    return shortMonths;
}

As you can see, the createShortforms function now gets the MONTHS array instead of the localized months. This function behaves like it should.

[maaikez]

When will this be fixed? Because it's such a simple fix (I think).

Not sure I follow the logic of the code, do you want to submit a pull request?

[shai-almog]

Fixed by #5105 (merged in defe5ed7b).

The fix was exactly what you proposed in the original report: pass the English WEEKDAYS array to createShortforms so the lookup key matches the documented WEEKDAY_SHORTNAME_<EnglishDay> convention, mirroring how getShortMonths() already used MONTHS. With WEEKDAY_SHORTNAME_MONDAY=ma in the bundle, getShortWeekdays()[Calendar.MONDAY-1] now correctly returns "ma" instead of "maa". Thanks for the detailed report and the proposed fix — sorry it took 11+ years.