Skip to content

Update ParparVM CI to test on multiple JDKs (11, 17, 21, 25) #4285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shai-almog merged 3 commits into from
Dec 17, 2025
Merged

Update ParparVM CI to test on multiple JDKs (11, 17, 21, 25) #4285

shai-almog merged 3 commits into from
Dec 17, 2025

Conversation

@google-labs-jules
Copy link
Contributor

@google-labs-jules google-labs-jules bot commented Dec 16, 2025

Updated the .github/workflows/parparvm-tests.yml workflow to include sequential test runs on JDK 11, 17, 21, and 25.
Updated vm/pom.xml to use ASM 9.7 to support running tests on newer JDKs.
Ensured JDK 8 runs last to preserve quality report generation.

PR created automatically by Jules for task 12596795933236961008 started by @shai-almog

@google-labs-jules
Update ParparVM CI to test on JDK 11, 17, 21, and 25
1367324 
This change updates the `parparvm-tests.yml` workflow to run the ParparVM
tests on JDK 11, 17, 21, and 25 (Early Access) in addition to the existing
JDK 8 run.

The tests are run sequentially. For JDK 11+, the execution is limited to
the `tests` module (and dependencies) to avoid compilation issues with the
`JavaAPI` module, which targets Java 1.5 (unsupported by newer JDKs).
JaCoCo is skipped for newer JDKs to avoid version conflicts.

The ASM library version in `vm/pom.xml` is updated to 9.7 to ensure
compatibility with JDK 21+ environments.

The existing JDK 8 run is moved to the end of the sequence to ensure the
generated coverage report reflects the primary supported environment.
@google-labs-jules
Copy link
Contributor Author

google-labs-jules bot commented Dec 16, 2025

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@github-actions
Copy link

github-actions bot commented Dec 16, 2025 •
edited
Loading

✅ ByteCodeTranslator Quality Report

Test & Coverage

  • ✅ Tests: 102 total, 0 failed, 0 skipped
  • ⚠️ Coverage report not generated.

Static Analysis

  • ✅ SpotBugs: no findings (report was not generated by the build).
  • ⚠️ PMD report not generated.
  • ⚠️ Checkstyle report not generated.

Generated automatically by the PR CI workflow.

@github-actions
Copy link

github-actions bot commented Dec 16, 2025 •
edited
Loading

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Generated automatically by the PR CI workflow.

@shai-almog
Copy link
Collaborator

shai-almog commented Dec 16, 2025 •
edited
Loading

iOS screenshot updates

Compared 30 screenshots: 26 matched, 3 updated, 1 missing reference.

  • BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    BrowserComponent
    Preview info: Preview provided by instrumentation.
    Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.

  • graphics-draw-gradient — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    graphics-draw-gradient
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.

  • graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

    graphics-draw-round-rect
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.

  • graphics-fill-arc — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    graphics-fill-arc
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-fill-arc.png in workflow artifacts.

@google-labs-jules
Update ParparVM tests to run against multiple JDKs and targets
5bd668f 
This change updates the CI workflow and the test infrastructure to support running
integration tests against multiple JDK versions (8, 11, 17, 21, and 25).

Changes:
- Updated `.github/workflows/parparvm-tests.yml` to install JDKs 8, 11, 17, 21, and 25
  and export their paths as environment variables. The main test execution remains
  on JDK 8.
- Created `CompilerHelper` in `vm/tests` to detect available JDKs from environment
  variables and manage compilation using `ProcessBuilder` instead of the in-process
  Compiler API. This avoids classpath pollution and supports newer JDKs.
- Updated `BytecodeInstructionIntegrationTest` and `CleanTargetIntegrationTest` to use
  `CompilerHelper` and run parameterized tests across valid permutations of
  available Compilers and Target Versions (1.5, 1.8, 11, 17, 21, 25).
- Added logic to handle `javac` flag changes on JDK 9+ (replacing `-bootclasspath`
  with `-classpath` or `--patch-module` as appropriate) and to skip invalid permutations.
- Updated `vm/pom.xml` to use ASM 9.7 to support newer Java class file versions.
@google-labs-jules
Update ParparVM CI to test cross-compilation on JDKs 8-25
6f37ce9 
This change updates the CI workflow and test infrastructure to validate
that the ParparVM ByteCodeTranslator correctly handles bytecode compiled
by JDKs 8, 11, 17, 21, and 25 against a range of target versions (1.5, 1.8,
11, 17, 21, 25).

Key changes:
- `.github/workflows/parparvm-tests.yml`: Installs JDKs 8, 11, 17, 21, and 25
  and exports their paths for use by the test suite.
- `vm/pom.xml`: Updated `asm.version` to 9.8 to support Java 25 class files.
- `vm/tests/.../CompilerHelper.java`: New helper to manage out-of-process
  `javac` execution using the detected JDK paths.
- `vm/tests/.../BytecodeInstructionIntegrationTest.java` & `CleanTargetIntegrationTest.java`:
  Refactored to use parameterized tests spanning the matrix of available JDKs
  and target versions. Added logic to adapt compilation flags (e.g., handling
  the removal of `-bootclasspath` in JDK 9+).
@shai-almog shai-almog marked this pull request as ready for review December 17, 2025 02:12
@chatgpt-codex-connector
Copy link

chatgpt-codex-connector bot commented Dec 17, 2025

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@shai-almog shai-almog merged commit 7fffa41 into master Dec 17, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shai-almog