Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

This PR adds benchmark measurements for the VM bytecode translation and native iOS compilation steps in the CI pipeline.

Changes

  • scripts/build-ios-app.sh: Added timing for the ./mvnw package command which performs the Bytecode to C translation. The duration is saved to vm_time.txt in the artifacts directory.
  • scripts/run-ios-ui-tests.sh: Added timing for the xcodebuild command. The VM time is read from the artifacts, and both times are exported as environment variables (CN1SS_VM_TIME, CN1SS_COMPILATION_TIME).
  • scripts/lib/cn1ss.sh: Updated the screenshot processing helper to pass these environment variables as arguments to the Java reporting tool.
  • scripts/common/java/RenderScreenshotReport.java: Added support for --vm-time and --compilation-time arguments. The report now includes a "Benchmark Results" section displaying these durations. Logic was updated to ensure the success message is still displayed when appropriate, even when benchmark data is present.

Example Output

The PR comment will now include a section like:

### Benchmark Results

- **VM Translation Time:** 123 seconds
- **Compilation Time:** 456 seconds

PR created automatically by Jules for task 8027837712868060644 started by @shai-almog

Measured and reported VM translation time and native compilation time in the PR comment.
Updated `scripts/build-ios-app.sh` to capture VM translation time.
Updated `scripts/run-ios-ui-tests.sh` to capture compilation time and pass metrics.
Updated `RenderScreenshotReport.java` to display benchmark results.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@shai-almog
Copy link
Collaborator

shai-almog commented Dec 17, 2025

iOS screenshot updates

Compared 30 screenshots: 27 matched, 2 updated, 1 missing reference.

  • BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    BrowserComponent
    Preview info: Preview provided by instrumentation.
    Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.

  • graphics-draw-gradient — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    graphics-draw-gradient
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.

  • graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

    graphics-draw-round-rect
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.

Benchmark Results

  • VM Translation Time: 326 seconds
  • Compilation Time: 110 seconds

@shai-almog shai-almog marked this pull request as ready for review December 17, 2025 05:59
@shai-almog shai-almog merged commit 258c0e9 into master Dec 17, 2025
7 checks passed
@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants