Fix redundant git clone and build delays in setup-workspace.sh #4290
Conversation
Explicitly disable the `download-cn1-binaries` Maven profile during the `setup-workspace.sh` script execution. The script already provisions these binaries externally and passes the path via `-Dcn1.binaries`, but the profile was still activating and attempting a redundant `git clone` into the target directory, causing concurrency errors (exit code 128) and significant delays.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
Android screenshot updatesCompared 30 screenshots: 26 matched, 4 updated.
Native Android coverage
|
Enhance build performance in `scripts/setup-workspace.sh` by: 1. Adding `-T 1C` to Maven commands to enable parallel builds using one thread per core. 2. Adding `-Dmaven.javadoc.skip=true` and `-Dmaven.source.skip=true` to skip time-consuming and unnecessary documentation and source artifact generation during the workspace setup phase. 3. Explicitly disabling the `download-cn1-binaries` profile (`-P !download-cn1-binaries`) to prevent redundant `git clone` operations that were causing "Result: 128" errors and delays.
1. Optimize `scripts/setup-workspace.sh` build time by enabling parallel builds (`-T 1C`) and skipping unnecessary Javadoc/Source generation. 2. Fix "Result: 128" git errors by explicitly disabling the `download-cn1-binaries` profile (`-P !download-cn1-binaries`). 3. Fix "Stubber.jar not found" build failure by explicitly passing `-Dcn1.binaries="$CN1_BINARIES"` to Maven commands, ensuring the external binaries are located. 4. Update `.github/workflows/pr.yml` to trigger the PR CI workflow when `scripts/setup-workspace.sh` is modified, enabling validation of these changes.
iOS screenshot updatesCompared 30 screenshots: 24 matched, 5 updated, 1 missing reference.
Benchmark Results
|
1. **Optimize `scripts/setup-workspace.sh`:**
* Enable parallel builds (`-T 1C`) for faster execution.
* Skip Javadoc and Source generation to save time.
* Explicitly disable the `download-cn1-binaries` profile (`-P !download-cn1-binaries`) to prevent redundant git operations and "Result: 128" errors.
* Pass `-Dcn1.binaries="$CN1_BINARIES"` to ensure the build can locate the pre-provisioned binaries.
2. **Fix `scripts/build-android-port.sh`:**
* Apply the same fixes as above (disable download profile, pass binaries path, optimization flags) to resolve "Result: 128" errors during the Android port build stage.
3. **Update `.github/workflows/pr.yml`:**
* Add `!scripts/setup-workspace.sh` to the `paths-ignore` list for both `push` and `pull_request` triggers. This ensures that changes to the setup script properly trigger the CI workflow for validation.
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
1. **Optimize `scripts/setup-workspace.sh`**:
* Enable parallel Maven builds (`-T 1C`) for faster execution.
* Skip Javadoc and source generation (`-Dmaven.javadoc.skip=true`, `-Dmaven.source.skip=true`).
* Disable the `download-cn1-binaries` profile (`-P !download-cn1-binaries`) to prevent redundant cloning and "Result: 128" errors.
* Explicitly pass `-Dcn1.binaries="$CN1_BINARIES"` to ensure binaries are located correctly.
2. **Fix `scripts/build-android-port.sh`**:
* Define `CN1_BINARIES` variable with fallback logic to prevent "unbound variable" errors.
* Apply the same Maven optimizations and profile deactivation as in `setup-workspace.sh` to resolve build failures.
3. **Update `.github/workflows/pr.yml`**:
* Add `!scripts/setup-workspace.sh` to `paths-ignore` for both `push` and `pull_request` triggers to ensure CI runs when this script is modified.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
The
setup-workspace.shscript was experiencing significant delays and failures (exit code 128) during the "Setup workspace" stage, particularly on macOS. This was caused by thedownload-cn1-binariesMaven profile activating despite the-Dcn1.binariessystem property being set. The profile would attempt to clone thecn1-binariesrepository into the target directory, conflicting with the script's logic which already provisions these binaries in a separate location. This change explicitly disables the profile (-P !download-cn1-binaries) for all Maven invocations within the script, ensuring the build relies solely on the pre-provisioned binaries and eliminating the redundant git operations.PR created automatically by Jules for task 9229016740564091027 started by @shai-almog