Add JDK 17, 21, 25 to PR CI Matrix #4305
Conversation
Modified .github/workflows/pr.yml to use a matrix strategy for testing across multiple JDK versions. Ensured that artifact generation, static analysis, and reporting steps are executed only for the default JDK 8 build. Retained legacy JDK 8 setup (with JavaFX) while using setup-java@v4 for newer JDKs.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
Modified maven/core/pom.xml and vm/JavaAPI/pom.xml to use Maven properties for compiler source/target settings. Added a 'modern-jdk' Maven profile activated on JDK 9+ to set compiler source/target to 1.8. This resolves 'Source option 5 is no longer supported' errors when building with newer JDKs in the CI matrix.
✅ ByteCodeTranslator Quality ReportTest & Coverage
Benchmark Results
Static Analysis
Generated automatically by the PR CI workflow. |
Android screenshot updatesCompared 30 screenshots: 29 matched, 1 updated.
Native Android coverage
|
Modified maven/parparvm/pom.xml to move the system dependency on tools.jar into a Maven profile active only for JDKs < 9. This prevents the 'Could not find artifact com.sun:tools:jar:1.5.0' error on newer JDKs (like 17+) where tools.jar has been removed.
Modified maven/parparvm/pom.xml to use Maven properties for the javac task source/target versions. Added a 'modern-jdk' Maven profile activated on JDK 9+ to override these properties to 1.8. This resolves the 'Source option 5 is no longer supported' error in the ParparVM build when running on newer JDKs.
Modified .github/workflows/pr.yml to pass -Djavac.source=1.8 -Djavac.target=1.8 to Ant commands when running on JDK 9+ (i.e., non-JDK 8 builds). This overrides the project.properties setting (1.6) which caused 'Source option 6 is no longer supported' errors on modern JDKs, while preserving the legacy configuration for the default JDK 8 pipeline.
Moved the 'Build CLDC11 JAR' step before 'Build with Ant' (test-javase) in pr.yml. This ensures the CLDC11 jar is pre-built with the correct compiler options (1.8) on modern JDKs, preventing the 'CodenameOneCLI' test runner from failing when attempting to rebuild it with default (1.6) options.
iOS screenshot updatesCompared 30 screenshots: 23 matched, 6 updated, 1 missing reference.
Benchmark Results
|
Modified .github/workflows/pr.yml to append -Dspotbugs.skip=true to the Maven command for all JDK versions except 8. This prevents build failures on newer JDKs (like JDK 25) caused by SpotBugs incompatibility with modern class file versions, while ensuring static analysis remains active for the default pipeline.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This change updates the PR CI workflow to run tests against JDK 8, 17, 21, and 25 using a matrix strategy. It ensures that reporting and artifact uploads are restricted to the default JDK 8 build to avoid duplication and noise. It also handles the different setup requirements for JDK 8 (requiring JavaFX) vs. newer JDKs.
PR created automatically by Jules for task 5236328697114802487 started by @shai-almog