Fix Spotbugs warnings: Add final modifier to constant fields #4317
Conversation
This commit resolves multiple "Field isn't final but should be" warnings identified by Spotbugs. The `final` modifier has been added to the following fields: - `ColorUtil`: `LTGRAY`, `BLUE`, `BLACK`, `WHITE`, `CYAN`, `GREEN`, `YELLOW`, `MAGENTA`, `GRAY` - `Cookie`: `STORAGE_NAME` - `Log`: `REPORTING_NONE`, `REPORTING_DEBUG`, `REPORTING_PRODUCTION` - `JavascriptContext`: `jsLookupTable` - `LocationRequest`: `PRIORITY_HIGH_ACCUARCY`, `PRIORITY_MEDIUM_ACCUARCY`, `PRIORITY_LOW_ACCUARCY` - `DocumentInfo`: `TYPE_HTML`, `TYPE_IMAGE`, `TYPE_CSS` - `PlatformDefaults`: `VISUAL_PADDING_PROPERTY` These fields are intended to be constants (or effectively final in the case of `jsLookupTable`) and enforcing immutability improves thread safety and code clarity. Existing typos in `LocationRequest` field names are preserved for backward compatibility.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
|
Compared 30 screenshots: 30 matched. Native Android coverage
✅ Native Android screenshot tests passed. Native Android coverage
|
iOS screenshot updatesCompared 30 screenshots: 24 matched, 5 updated, 1 missing reference.
Benchmark Results
Detailed Performance Metrics
|
This commit resolves multiple "Field isn't final but should be" warnings identified by Spotbugs. The `final` modifier has been added to the following fields: - `ColorUtil`: `LTGRAY`, `BLUE`, `BLACK`, `WHITE`, `CYAN`, `GREEN`, `YELLOW`, `MAGENTA`, `GRAY` - `Cookie`: `STORAGE_NAME` - `Log`: `REPORTING_NONE`, `REPORTING_DEBUG`, `REPORTING_PRODUCTION` - `JavascriptContext`: `DEBUG` - `LocationRequest`: `PRIORITY_HIGH_ACCUARCY`, `PRIORITY_MEDIUM_ACCUARCY`, `PRIORITY_LOW_ACCUARCY` - `DocumentInfo`: `TYPE_HTML`, `TYPE_IMAGE`, `TYPE_CSS` - `PlatformDefaults`: `VISUAL_PADDING_PROPERTY` These fields are intended to be constants (or effectively final in the case of `DEBUG`) and enforcing immutability improves thread safety and code clarity. Existing typos in `LocationRequest` field names are preserved for backward compatibility.
Resolved Spotbugs warnings by adding the
finalmodifier to several static fields and one instance field acrossColorUtil,Cookie,Log,JavascriptContext,LocationRequest,DocumentInfo, andPlatformDefaults. These fields are constants or effectively final, and explicitly marking them as such prevents accidental modification. Verified changes by running relevant core unit tests (CookieTest).PR created automatically by Jules for task 6771464511387895335 started by @shai-almog