Fixed spotbugs recursive bugs

[shai-almog]

No description provided.

[github-actions]

✅ Continuous Quality Report

Test & Coverage

• ✅ Tests: 2276 total, 0 failed, 0 skipped
• 📊 Line coverage: 52.87% [HTML preview] [Download]
  • Lowest covered classes
    • com.codename1.ui.BrowserWindow$BrowserForm – 0.00%
    • com.codename1.processing.TextEvaluator – 3.45%
    • com.codename1.charts.views.PieChart – 4.00%
    • com.codename1.charts.views.PieMapper – 4.88%
    • com.codename1.charts.views.ScatterChart – 5.32%
    • com.codename1.ui.list.GenericListCellRenderer$Monitor – 5.33%
    • com.codename1.ui.Display$EdtException – 5.56%
    • com.codename1.testing.AbstractTest – 6.05%
    • com.codename1.ui.Transform$ImmutableTransform – 6.06%
    • com.codename1.charts.views.DoughnutChart – 6.25%

Static Analysis

• ❌ SpotBugs: 823 findings (High: 68, Normal: 469, Low: 286) [HTML preview] [Download]
  • Top findings
    • High: CodenameOne/src/com/codename1/charts/views/XYChart.java:128 – Call to equals() comparing different types (rule: EC_UNRELATED_TYPES)
    • High: CodenameOne/src/com/codename1/compat/java/util/Objects.java:51 – Redundant nullcheck of value known to be non-null (rule: RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE)
    • High: CodenameOne/src/com/codename1/components/ImageViewer.java:310 – Condition has no effect (rule: UC_USELESS_CONDITION)
    • High: CodenameOne/src/com/codename1/components/InteractionDialog.java:639 – Possible null pointer dereference (rule: NP_NULL_ON_SOME_PATH)
    • High: CodenameOne/src/com/codename1/components/ToastBar.java:1021 – Potentially ambiguous invocation of either an inherited or outer method (rule: IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD)
    • …and 818 more
• ❌ PMD: 2711 findings (P2: 1, P3: 633, P4: 2077) [HTML preview] [Download]
  • Top findings
    • P2: CodenameOne/src/com/codename1/ui/Display.java:1022 – Avoid using a branching statement as the last in a loop. (rule: AvoidBranchingStatementAsLastInLoop)
    • P3: CodenameOne/src/com/codename1/charts/views/LineChart.java:208 – These nested if statements could be combined (rule: CollapsibleIfStatements)
    • P3: CodenameOne/src/com/codename1/facebook/FacebookRESTService.java:76 – Avoid unused constructor parameters such as 'token'. (rule: UnusedFormalParameter)
    • P3: CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java:8443 – These nested if statements could be combined (rule: CollapsibleIfStatements)
    • P3: CodenameOne/src/com/codename1/impl/FullScreenAdService.java:103 – These nested if statements could be combined (rule: CollapsibleIfStatements)
    • …and 2706 more
• ❌ Checkstyle: 219869 findings (Warning: 219869) [HTML preview] [Download]
  • Top findings
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:30:1 – Extra separation in import group before 'java.io.IOException' (rule: CustomImportOrderCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:32 – First sentence of Javadoc is missing an ending period. (rule: SummaryJavadocCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:36 – Line is longer than 100 characters (found 143). (rule: LineLengthCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:39:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:40:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
    • …and 219864 more

Generated automatically by the PR CI workflow.

[shai-almog]

Compared 30 screenshots: 30 matched.

Native Android coverage

• 📊 Line coverage: 24.61% (2625/10667 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
  • Other counters: instruction 24.16% (12162/50336), branch 15.11% (701/4640), complexity 17.27% (729/4220), method 32.40% (588/1815), class 33.99% (103/303)
  • Lowest covered classes
    • com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
    • com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidDB – 0.00% (0/57 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

• 📊 Line coverage: 24.61% (2625/10667 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
  • Other counters: instruction 24.16% (12162/50336), branch 15.11% (701/4640), complexity 17.27% (729/4220), method 32.40% (588/1815), class 33.99% (103/303)
  • Lowest covered classes
    • com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
    • com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidDB – 0.00% (0/57 lines covered)

[shai-almog]

iOS screenshot updates

Compared 30 screenshots: 24 matched, 5 updated, 1 missing reference.

• BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: Preview provided by instrumentation.
  Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.

• graphics-draw-gradient — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
  Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.

• graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

  
  Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
  Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.

• graphics-draw-string — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
  Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.

• graphics-draw-string-decorated — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
  Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.

• kotlin — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: Preview provided by instrumentation.
  Full-resolution PNG saved as kotlin.png in workflow artifacts.

Benchmark Results

• VM Translation Time: 258 seconds
• Compilation Time: 49 seconds

Detailed Performance Metrics

Metric	Duration
Build Time Statistics
Setup & Unzip	23857 ms
Extract Extensions	13 ms
Google Services Setup	2 ms
Scan Classes	431 ms
Extract Libs	817 ms
Inject Build Hints	28 ms
Generate Unit Tests	2 ms
Generate Stubs	780 ms
Compile Stubs	1874 ms
Generate Icons	910 ms
Prepare ParparVM	115 ms
ParparVM Execution	151181 ms
Post-VM Setup	116 ms
CocoaPods	4127 ms
Finalize	24 ms
Total Time	184277 msMaven Overhead : 74000 ms
CocoaPods Install (Script)	1000 ms
Simulator Boot (Run)	61000 ms
App Install	27000 ms
App Launch	42000 ms
Test Execution	149000 ms