Fix SpotBugs warnings in CodenameOneImplementation and UIBuilder

[google-labs-jules]

This PR addresses two SpotBugs warnings:

1. Incorrect combination of Math.max and Math.min in CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java. The code was calculating startX = Math.min(startY, 2f) where startY was guaranteed to be >= 5, resulting in startX always being 2f regardless of its initial value. This was corrected to startX = Math.min(startX, 2f).
2. Incorrect lazy initialization and update of static field in CodenameOne/src/com/codename1/ui/util/UIBuilder.java. The getComponentRegistry method was lazy-initializing a static Hashtable without synchronization, leading to potential race conditions. The method is now synchronized.

---

PR created automatically by Jules for task 3735162987392763748 started by @shai-almog

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

---

For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

[github-actions]

✅ Continuous Quality Report

Test & Coverage

• ✅ Tests: 2276 total, 0 failed, 0 skipped
• 📊 Line coverage: 52.94% [HTML preview] [Download]
  • Lowest covered classes
    • com.codename1.ui.BrowserWindow$BrowserForm – 0.00%
    • com.codename1.processing.TextEvaluator – 3.45%
    • com.codename1.charts.views.PieChart – 4.00%
    • com.codename1.charts.views.PieMapper – 4.88%
    • com.codename1.charts.views.ScatterChart – 5.32%
    • com.codename1.ui.list.GenericListCellRenderer$Monitor – 5.33%
    • com.codename1.ui.Display$EdtException – 5.56%
    • com.codename1.testing.AbstractTest – 6.05%
    • com.codename1.ui.Transform$ImmutableTransform – 6.06%
    • com.codename1.charts.views.DoughnutChart – 6.25%

Static Analysis

• ❌ SpotBugs: 801 findings (High: 66, Normal: 459, Low: 276) [HTML preview] [Download]
  • Top findings
    • High: CodenameOne/src/com/codename1/charts/views/XYChart.java:128 – Call to equals() comparing different types (rule: EC_UNRELATED_TYPES)
    • High: CodenameOne/src/com/codename1/compat/java/util/Objects.java:51 – Redundant nullcheck of value known to be non-null (rule: RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE)
    • High: CodenameOne/src/com/codename1/components/ImageViewer.java:310 – Condition has no effect (rule: UC_USELESS_CONDITION)
    • High: CodenameOne/src/com/codename1/components/InteractionDialog.java:639 – Possible null pointer dereference (rule: NP_NULL_ON_SOME_PATH)
    • High: CodenameOne/src/com/codename1/components/ToastBar.java:1021 – Potentially ambiguous invocation of either an inherited or outer method (rule: IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD)
    • …and 796 more
• ❌ PMD: 2711 findings (P2: 1, P3: 633, P4: 2077) [HTML preview] [Download]
  • Top findings
    • P2: CodenameOne/src/com/codename1/ui/Display.java:1022 – Avoid using a branching statement as the last in a loop. (rule: AvoidBranchingStatementAsLastInLoop)
    • P3: CodenameOne/src/com/codename1/charts/views/LineChart.java:208 – These nested if statements could be combined (rule: CollapsibleIfStatements)
    • P3: CodenameOne/src/com/codename1/facebook/FacebookRESTService.java:76 – Avoid unused constructor parameters such as 'token'. (rule: UnusedFormalParameter)
    • P3: CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java:8443 – These nested if statements could be combined (rule: CollapsibleIfStatements)
    • P3: CodenameOne/src/com/codename1/impl/FullScreenAdService.java:103 – These nested if statements could be combined (rule: CollapsibleIfStatements)
    • …and 2706 more
• ❌ Checkstyle: 219871 findings (Warning: 219871) [HTML preview] [Download]
  • Top findings
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:30:1 – Extra separation in import group before 'java.io.IOException' (rule: CustomImportOrderCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:32 – First sentence of Javadoc is missing an ending period. (rule: SummaryJavadocCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:36 – Line is longer than 100 characters (found 143). (rule: LineLengthCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:39:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:40:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
    • …and 219866 more

Generated automatically by the PR CI workflow.

[shai-almog]

Compared 30 screenshots: 30 matched.

Native Android coverage

• 📊 Line coverage: 24.72% (2637/10667 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
  • Other counters: instruction 24.32% (12243/50336), branch 15.15% (703/4640), complexity 17.42% (735/4220), method 32.84% (596/1815), class 34.98% (106/303)
  • Lowest covered classes
    • com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
    • com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidDB – 0.00% (0/57 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

• 📊 Line coverage: 24.72% (2637/10667 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
  • Other counters: instruction 24.32% (12243/50336), branch 15.15% (703/4640), complexity 17.42% (735/4220), method 32.84% (596/1815), class 34.98% (106/303)
  • Lowest covered classes
    • com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
    • com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidDB – 0.00% (0/57 lines covered)

[shai-almog]

iOS screenshot updates

Compared 30 screenshots: 23 matched, 6 updated, 1 missing reference.

• BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: Preview provided by instrumentation.
  Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.

• graphics-draw-arc — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 603x1311.
  Full-resolution PNG saved as graphics-draw-arc.png in workflow artifacts.

• graphics-draw-gradient — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
  Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.

• graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

  
  Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
  Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.

• graphics-draw-string — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
  Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.

• graphics-draw-string-decorated — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
  Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.

• kotlin — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: Preview provided by instrumentation.
  Full-resolution PNG saved as kotlin.png in workflow artifacts.

Benchmark Results

• VM Translation Time: 286 seconds
• Compilation Time: 52 seconds

Detailed Performance Metrics

Metric	Duration
Build Time Statistics
Setup & Unzip	27160 ms
Extract Extensions	13 ms
Google Services Setup	3 ms
Scan Classes	446 ms
Extract Libs	696 ms
Inject Build Hints	28 ms
Generate Unit Tests	3 ms
Generate Stubs	1297 ms
Compile Stubs	2464 ms
Generate Icons	1196 ms
Prepare ParparVM	157 ms
ParparVM Execution	161254 ms
Post-VM Setup	98 ms
CocoaPods	4507 ms
Finalize	11 ms
Total Time	199333 msMaven Overhead : 87000 ms
CocoaPods Install (Script)	1000 ms
Simulator Boot (Run)	42000 ms
App Install	22000 ms
App Launch	7000 ms
Test Execution	136000 ms