Fix SMS and Dialing support on Android tablets and foldables #4330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change decouples telephony capabilities from the form factor check (`isTablet`). Previously, `canDial()` returned `false` if `isTablet()` was true, which caused `getSMSSupport()` to return `SMS_NOT_SUPPORTED` on large-screen devices even if they had telephony hardware (like the Galaxy Fold). Changes: - Override `canDial()` in `AndroidImplementation` to explicitly check for `PackageManager.FEATURE_TELEPHONY`. - This ensures `getSMSSupport()` returns `SMS_INTERACTIVE` on all devices with telephony hardware, regardless of screen size. - `isTablet()` remains based on screen layout size to preserve correct UI behavior.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
Collaborator
|
Compared 30 screenshots: 30 matched. Native Android coverage
✅ Native Android screenshot tests passed. Native Android coverage
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Android devices, such as the Galaxy Fold, are detected as tablets by Codename One due to their screen size. As a result, the
canDial()method (which defaulted to!isTablet()) returnedfalse, causinggetSMSSupport()to returnSMS_NOT_SUPPORTED. This prevented apps from sending SMS or dialing on these devices.This PR overrides
canDial()inAndroidImplementationto check for thePackageManager.FEATURE_TELEPHONYsystem feature instead of relying on the device form factor. This ensures that any device with telephony hardware, including tablets and foldables, can correctly use dialing and SMS features. TheisTablet()logic remains unchanged to ensure the UI adapts correctly to the larger screen size.PR created automatically by Jules for task 5804867896020162395 started by @shai-almog