Fix SpotBugs SF_SWITCH_NO_DEFAULT warnings #4350

google-labs-jules · 2025-12-25T03:34:40Z

Fixed "Switch statement found where default case is missing" warnings across multiple files and promoted the warning to an error in the quality report script. Verified by compiling the core library.

PR created automatically by Jules for task 2790825227576484200 started by @shai-almog

This commit addresses missing default cases in switch statements across the codebase, as flagged by SpotBugs (SF_SWITCH_NO_DEFAULT). Key changes: - Added `default: break;` or appropriate fallback logic to switch statements in `CodenameOne/src` files including Charts, Components, UI, Layouts, and Utils. - Updated `.github/scripts/generate-quality-report.py` to treat `SF_SWITCH_NO_DEFAULT` as a forbidden rule, causing the build to fail if new violations are introduced. - Verified compilation of `codenameone-core` to ensure no syntax errors (e.g., duplicate labels) were introduced.

google-labs-jules · 2025-12-25T03:34:42Z

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

…484200

…tps://github.com/codenameone/CodenameOne into fix-spotbugs-switch-defaults-2790825227576484200

shai-almog · 2025-12-25T04:45:08Z

Compared 30 screenshots: 30 matched.

Native Android coverage

📊 Line coverage: 24.58% (2633/10711 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 24.10% (12172/50505), branch 15.02% (701/4668), complexity 17.28% (732/4237), method 32.56% (592/1818), class 33.99% (103/303)
- Lowest covered classes
  - com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
  - com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

📊 Line coverage: 24.58% (2633/10711 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 24.10% (12172/50505), branch 15.02% (701/4668), complexity 17.28% (732/4237), method 32.56% (592/1818), class 33.99% (103/303)
- Lowest covered classes
  - com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
  - com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

shai-almog · 2025-12-25T04:57:14Z

iOS screenshot updates

Compared 30 screenshots: 23 matched, 6 updated, 1 missing reference.

BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.
graphics-draw-arc — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-arc.png in workflow artifacts.
graphics-draw-gradient — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.
graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.
graphics-draw-string — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.
graphics-draw-string-decorated — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.
kotlin — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as kotlin.png in workflow artifacts.

Benchmark Results

VM Translation Time: 295 seconds
Compilation Time: 58 seconds

Detailed Performance Metrics

Metric	Duration
Build Time Statistics
Setup & Unzip	29586 ms
Extract Extensions	14 ms
Google Services Setup	2 ms
Scan Classes	603 ms
Extract Libs	1092 ms
Inject Build Hints	44 ms
Generate Unit Tests	3 ms
Generate Stubs	848 ms
Compile Stubs	2606 ms
Generate Icons	1233 ms
Prepare ParparVM	241 ms
ParparVM Execution	162110 ms
Post-VM Setup	144 ms
CocoaPods	4208 ms
Finalize	40 ms
Total Time	202775 msMaven Overhead : 93000 ms
CocoaPods Install (Script)	1000 ms
Simulator Boot (Run)	44000 ms
App Install	17000 ms
App Launch	11000 ms
Test Execution	139000 ms

github-actions · 2025-12-25T06:02:35Z

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 2280 total, 0 failed, 0 skipped
📊 Line coverage: 52.88% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.ui.BrowserWindow$BrowserForm – 0.00%
  - com.codename1.processing.TextEvaluator – 3.85%
  - com.codename1.charts.views.PieChart – 4.00%
  - com.codename1.charts.views.PieMapper – 4.88%
  - com.codename1.charts.views.ScatterChart – 5.32%
  - com.codename1.ui.list.GenericListCellRenderer$Monitor – 5.33%
  - com.codename1.ui.Display$EdtException – 5.56%
  - com.codename1.testing.AbstractTest – 6.05%
  - com.codename1.ui.Transform$ImmutableTransform – 6.06%
  - com.codename1.charts.views.DoughnutChart – 6.25%

Static Analysis

❌ SpotBugs: 609 findings (High: 56, Normal: 343, Low: 210) [HTML preview] [Download]
- Top findings
  - High: CodenameOne/src/com/codename1/charts/views/XYChart.java:128 – Call to equals() comparing different types (rule: EC_UNRELATED_TYPES)
  - High: CodenameOne/src/com/codename1/components/ImageViewer.java:310 – Condition has no effect (rule: UC_USELESS_CONDITION)
  - High: CodenameOne/src/com/codename1/components/ToastBar.java:1024 – Potentially ambiguous invocation of either an inherited or outer method (rule: IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD)
  - High: CodenameOne/src/com/codename1/facebook/FaceBookAccess.java:191 – Reliance on default encoding (rule: DM_DEFAULT_ENCODING)
  - High: CodenameOne/src/com/codename1/io/BufferedInputStream.java:441 – Reliance on default encoding (rule: DM_DEFAULT_ENCODING)
  - …and 604 more
❌ PMD: 2711 findings (P2: 1, P3: 634, P4: 2076) [HTML preview] [Download]
- Top findings
  - P2: CodenameOne/src/com/codename1/ui/Display.java:1022 – Avoid using a branching statement as the last in a loop. (rule: AvoidBranchingStatementAsLastInLoop)
  - P3: CodenameOne/src/com/codename1/charts/views/LineChart.java:208 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - P3: CodenameOne/src/com/codename1/facebook/FacebookRESTService.java:76 – Avoid unused constructor parameters such as 'token'. (rule: UnusedFormalParameter)
  - P3: CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java:8470 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - P3: CodenameOne/src/com/codename1/impl/FullScreenAdService.java:103 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - …and 2706 more
❌ Checkstyle: 220153 findings (Warning: 220153) [HTML preview] [Download]
- Top findings
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:30:1 – Extra separation in import group before 'java.io.IOException' (rule: CustomImportOrderCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:32 – First sentence of Javadoc is missing an ending period. (rule: SummaryJavadocCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:36 – Line is longer than 100 characters (found 143). (rule: LineLengthCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:39:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:40:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - …and 220148 more

Generated automatically by the PR CI workflow.

Merge branch 'master' into fix-spotbugs-switch-defaults-2790825227576…

f4eeed1

…484200

shai-almog marked this pull request as ready for review December 25, 2025 04:15

shai-almog added 2 commits December 25, 2025 06:31

Fixed verification issues due to merge

2fb24b2

Merge branch 'fix-spotbugs-switch-defaults-2790825227576484200' of ht…

3fb24f1

…tps://github.com/codenameone/CodenameOne into fix-spotbugs-switch-defaults-2790825227576484200

More issues due to the merge problem

78a1c91

shai-almog force-pushed the fix-spotbugs-switch-defaults-2790825227576484200 branch from b1f3c51 to 78a1c91 Compare December 25, 2025 05:55

shai-almog merged commit c43fc81 into master Dec 25, 2025
17 of 21 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix SpotBugs SF_SWITCH_NO_DEFAULT warnings #4350

Fix SpotBugs SF_SWITCH_NO_DEFAULT warnings #4350

Uh oh!

google-labs-jules bot commented Dec 25, 2025

Uh oh!

google-labs-jules bot commented Dec 25, 2025

Uh oh!

shai-almog commented Dec 25, 2025 •

edited

Loading

Uh oh!

shai-almog commented Dec 25, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix SpotBugs SF_SWITCH_NO_DEFAULT warnings #4350

Fix SpotBugs SF_SWITCH_NO_DEFAULT warnings #4350

Uh oh!

Conversation

google-labs-jules bot commented Dec 25, 2025

Uh oh!

google-labs-jules bot commented Dec 25, 2025

Uh oh!

shai-almog commented Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Native Android coverage

Native Android coverage

Uh oh!

shai-almog commented Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS screenshot updates

Benchmark Results

Detailed Performance Metrics

Uh oh!

github-actions bot commented Dec 25, 2025

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shai-almog commented Dec 25, 2025 •

edited

Loading

shai-almog commented Dec 25, 2025 •

edited

Loading