Fix SpotBugs Repeated Conditional Tests #4360

google-labs-jules · 2025-12-25T16:59:01Z

Fixed 4 instances of repeated conditional tests identified by SpotBugs and updated the quality report script to fail on this violation in the future.

Note: One reported instance in BrowserComponent.java could not be reproduced/located with the given line number and file content, but the other 4 definite bugs are fixed.

PR created automatically by Jules for task 12659235444226235499 started by @shai-almog

Fixed RpC_REPEATED_CONDITIONAL_TEST violations in: - GridBagConstraints.java: Fixed copy-paste error in insets check - CSSBorder.java: Fixed redundant quote check - ImageViewer.java: Fixed logic in keyReleased method - Container.java: Simplified componentAt logic Updated generate-quality-report.py to enforce this rule.

google-labs-jules · 2025-12-25T16:59:02Z

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

shai-almog · 2025-12-25T17:12:34Z

Compared 30 screenshots: 30 matched.

Native Android coverage

📊 Line coverage: 24.73% (2649/10711 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 24.36% (12304/50505), branch 15.25% (712/4668), complexity 17.42% (738/4237), method 32.84% (597/1818), class 34.98% (106/303)
- Lowest covered classes
  - com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
  - com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

📊 Line coverage: 24.73% (2649/10711 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 24.36% (12304/50505), branch 15.25% (712/4668), complexity 17.42% (738/4237), method 32.84% (597/1818), class 34.98% (106/303)
- Lowest covered classes
  - com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
  - com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

Fixed RpC_REPEATED_CONDITIONAL_TEST violations in: - GridBagConstraints.java: Fixed copy-paste error in insets check - CSSBorder.java: Fixed redundant quote check - ImageViewer.java: Fixed logic in keyReleased method - Container.java: Simplified componentAt logic - Form.java: Removed redundant nested if check Updated generate-quality-report.py to enforce this rule.

github-actions · 2025-12-25T17:33:17Z

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 2280 total, 0 failed, 0 skipped
📊 Line coverage: 52.84% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.ui.BrowserWindow$BrowserForm – 0.00%
  - com.codename1.processing.TextEvaluator – 3.85%
  - com.codename1.charts.views.PieChart – 4.00%
  - com.codename1.charts.views.PieMapper – 4.88%
  - com.codename1.charts.views.ScatterChart – 5.32%
  - com.codename1.ui.list.GenericListCellRenderer$Monitor – 5.33%
  - com.codename1.ui.Display$EdtException – 5.56%
  - com.codename1.testing.AbstractTest – 6.05%
  - com.codename1.ui.Transform$ImmutableTransform – 6.06%
  - com.codename1.charts.views.DoughnutChart – 6.25%

Static Analysis

❌ SpotBugs: 555 findings (High: 17, Normal: 333, Low: 205) [HTML preview] [Download]
- Top findings
  - High: CodenameOne/src/com/codename1/charts/views/XYChart.java:128 – Call to equals() comparing different types (rule: EC_UNRELATED_TYPES)
  - High: CodenameOne/src/com/codename1/io/NetworkManager.java:1064 – equals method always returns false (rule: EQ_ALWAYS_FALSE)
  - High: CodenameOne/src/com/codename1/io/gzip/InfBlocks.java:153 – Self assignment of field (rule: SA_FIELD_SELF_ASSIGNMENT)
  - High: CodenameOne/src/com/codename1/io/gzip/InfBlocks.java:154 – Self assignment of field (rule: SA_FIELD_SELF_ASSIGNMENT)
  - High: CodenameOne/src/com/codename1/io/gzip/InfBlocks.java:158 – Self assignment of field (rule: SA_FIELD_SELF_ASSIGNMENT)
  - …and 550 more
❌ PMD: 2720 findings (P2: 1, P3: 632, P4: 2087) [HTML preview] [Download]
- Top findings
  - P2: CodenameOne/src/com/codename1/ui/Display.java:1022 – Avoid using a branching statement as the last in a loop. (rule: AvoidBranchingStatementAsLastInLoop)
  - P3: CodenameOne/src/com/codename1/charts/views/LineChart.java:208 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - P3: CodenameOne/src/com/codename1/facebook/FacebookRESTService.java:76 – Avoid unused constructor parameters such as 'token'. (rule: UnusedFormalParameter)
  - P3: CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java:8470 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - P3: CodenameOne/src/com/codename1/impl/FullScreenAdService.java:103 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - …and 2715 more
❌ Checkstyle: 220210 findings (Warning: 220210) [HTML preview] [Download]
- Top findings
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:30:1 – Extra separation in import group before 'java.io.IOException' (rule: CustomImportOrderCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:32 – First sentence of Javadoc is missing an ending period. (rule: SummaryJavadocCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:36 – Line is longer than 100 characters (found 143). (rule: LineLengthCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:39:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:40:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - …and 220205 more

Generated automatically by the PR CI workflow.

shai-almog · 2025-12-25T17:55:10Z

iOS screenshot updates

Compared 30 screenshots: 23 matched, 6 updated, 1 missing reference.

BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.
graphics-draw-arc — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-arc.png in workflow artifacts.
graphics-draw-gradient — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.
graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.
graphics-draw-string — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.
graphics-draw-string-decorated — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.
kotlin — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as kotlin.png in workflow artifacts.

Benchmark Results

VM Translation Time: 339 seconds
Compilation Time: 85 seconds

Detailed Performance Metrics

Metric	Duration
Build Time Statistics
Setup & Unzip	35869 ms
Extract Extensions	38 ms
Google Services Setup	2 ms
Scan Classes	733 ms
Extract Libs	1557 ms
Inject Build Hints	64 ms
Generate Unit Tests	4 ms
Generate Stubs	1563 ms
Compile Stubs	2963 ms
Generate Icons	1245 ms
Prepare ParparVM	201 ms
ParparVM Execution	190786 ms
Post-VM Setup	193 ms
CocoaPods	6682 ms
Finalize	67 ms
Total Time	241967 msMaven Overhead : 98000 ms
CocoaPods Install (Script)	2000 ms
Simulator Boot (Run)	67000 ms
App Install	20000 ms
App Launch	14000 ms
Test Execution	206000 ms

shai-almog marked this pull request as ready for review December 25, 2025 18:05

shai-almog merged commit 269e17b into master Dec 25, 2025
13 of 19 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix SpotBugs Repeated Conditional Tests #4360

Fix SpotBugs Repeated Conditional Tests #4360

Uh oh!

google-labs-jules bot commented Dec 25, 2025

Uh oh!

google-labs-jules bot commented Dec 25, 2025

Uh oh!

shai-almog commented Dec 25, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 25, 2025

Uh oh!

shai-almog commented Dec 25, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix SpotBugs Repeated Conditional Tests #4360

Fix SpotBugs Repeated Conditional Tests #4360

Uh oh!

Conversation

google-labs-jules bot commented Dec 25, 2025

Uh oh!

google-labs-jules bot commented Dec 25, 2025

Uh oh!

shai-almog commented Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Native Android coverage

Native Android coverage

Uh oh!

github-actions bot commented Dec 25, 2025

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Uh oh!

shai-almog commented Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS screenshot updates

Benchmark Results

Detailed Performance Metrics

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shai-almog commented Dec 25, 2025 •

edited

Loading

shai-almog commented Dec 25, 2025 •

edited

Loading