Respect interface hierarchy for default methods in vtable generation

[shai-almog]

Motivation

• The existing default-method support did not account for interface hierarchies, so a subinterface default method that calls super would not correctly replace the base interface entry in the virtual method table.
• This could lead to incorrect generated C code where implementing classes point vtable slots at the base interface default instead of the overriding subinterface default.

Description

• Add a helper isInterfaceInHierarchy to detect when a class name appears in an interface's inheritance chain.
• Modify fillVirtualMethodTable to allow an interface method to replace a base-interface entry when the current class is an interface and the existing entry belongs to an interface in its hierarchy.
• Add a regression test translatesDefaultInterfaceMethodOverridesWithSuperCalls in ParserTest which generates a base interface, derived interface that invokes super, and an implementation, and asserts both the derived method calls the base default and that the implementation points its vtable to the derived default.

Testing

• Executed mvn -Dtest=ParserTest test in vm/tests to exercise the updated ParserTest including translatesDefaultInterfaceMethodOverridesWithSuperCalls.
• The Maven run failed due to an unresolved dependency com.codename1.parparvm:ByteCodeTranslator:jar:1.0-SNAPSHOT, so the test suite could not complete in this environment.

---

Codex Task

[github-actions]

✅ Continuous Quality Report

Test & Coverage

• ✅ Tests: 2282 total, 0 failed, 0 skipped
• 📊 Line coverage: 52.88% [HTML preview] [Download]
  • Lowest covered classes
    • com.codename1.io.rest.RequestBuilder$FetchAsPropertyListActionListener – 0.00%
    • com.codename1.io.rest.RequestBuilder$FetchAsPropertiesActionListener – 0.00%
    • com.codename1.ui.Display$EdtException – 0.00%
    • com.codename1.ui.BrowserWindow$BrowserForm – 0.00%
    • com.codename1.ui.plaf.CSSBorder$LinearGradient – 0.00%
    • com.codename1.io.rest.RequestBuilder$GetAsStringAsyncImplActionListener – 0.00%
    • com.codename1.io.rest.RequestBuilder$GetAsJsonMapActionListener – 0.00%
    • com.codename1.payment.Purchase$SynchronizeReceiptsSyncRunnable – 0.00%
    • com.codename1.io.rest.RequestBuilder$GetAsBytesAsyncImplActionListener – 0.00%
    • com.codename1.io.rest.RequestBuilder$FetchAsJsonMapActionListener – 0.00%

Static Analysis

• ❌ SpotBugs: 172 findings (Normal: 107, Low: 65) [HTML preview] [Download]
  • Top findings
    • Normal: CodenameOne/src/com/codename1/capture/Capture.java:262 – Naked notify in com.codename1.capture.Capture$CallBack.actionPerformed(ActionEvent) (rule: NN_NAKED_NOTIFY)
    • Normal: CodenameOne/src/com/codename1/charts/ChartComponent.java:489 – Integral division result cast to double or float in com.codename1.charts.ChartComponent.pointerDragged(int[], int[]) (rule: ICAST_IDIV_CAST_TO_DOUBLE)
    • Normal: CodenameOne/src/com/codename1/charts/ChartComponent.java:682 – Return value of com.codename1.charts.renderers.XYMultipleSeriesRenderer.isPanEnabled() ignored, but method has no side effect (rule: RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT)
    • Normal: CodenameOne/src/com/codename1/charts/ChartComponent.java:770 – Return value of com.codename1.charts.renderers.XYMultipleSeriesRenderer.isZoomEnabled() ignored, but method has no side effect (rule: RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT)
    • Normal: CodenameOne/src/com/codename1/charts/compat/Paint.java:38 – Unused field: com.codename1.charts.compat.Paint.g (rule: UUF_UNUSED_FIELD)
    • …and 167 more
• ❌ PMD: 2574 findings (P2: 1, P3: 503, P4: 2070) [HTML preview] [Download]
  • Top findings
    • P2: CodenameOne/src/com/codename1/ui/Display.java:1040 – Avoid using a branching statement as the last in a loop. (rule: AvoidBranchingStatementAsLastInLoop)
    • P3: CodenameOne/src/com/codename1/charts/views/LineChart.java:208 – These nested if statements could be combined (rule: CollapsibleIfStatements)
    • P3: CodenameOne/src/com/codename1/components/RSSReader.java:500 – Overriding method merely calls super (rule: UselessOverridingMethod)
    • P3: CodenameOne/src/com/codename1/facebook/Album.java:198 – Overriding method merely calls super (rule: UselessOverridingMethod)
    • P3: CodenameOne/src/com/codename1/facebook/FaceBookAccess.java:1312 – Unnecessary semicolon (rule: UnnecessarySemicolon)
    • …and 2569 more
• ❌ Checkstyle: 220822 findings (Warning: 220822) [HTML preview] [Download]
  • Top findings
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:30:1 – Extra separation in import group before 'java.io.IOException' (rule: CustomImportOrderCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:32 – First sentence of Javadoc is missing an ending period. (rule: SummaryJavadocCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:36 – Line is longer than 100 characters (found 143). (rule: LineLengthCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:39:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:40:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
    • …and 220817 more

Generated automatically by the PR CI workflow.

[github-actions]

✅ ByteCodeTranslator Quality Report

Test & Coverage

• ✅ Tests: 171 total, 0 failed, 2 skipped

Benchmark Results

• Execution Time: 10262 ms

• Hotspots (Top 20 sampled methods):

  • 22.67% java.lang.String.indexOf (399 samples)
  • 18.98% java.util.ArrayList.indexOf (334 samples)
  • 17.10% com.codename1.tools.translator.Parser.isMethodUsed (301 samples)
  • 5.57% com.codename1.tools.translator.BytecodeMethod.addToConstantPool (98 samples)
  • 5.34% java.lang.Object.hashCode (94 samples)
  • 3.24% com.codename1.tools.translator.ByteCodeClass.calcUsedByNative (57 samples)
  • 2.56% java.lang.System.identityHashCode (45 samples)
  • 1.88% com.codename1.tools.translator.BytecodeMethod.optimize (33 samples)
  • 1.70% com.codename1.tools.translator.Parser.generateClassAndMethodIndexHeader (30 samples)
  • 1.65% com.codename1.tools.translator.ByteCodeClass.markDependent (29 samples)
  • 1.36% java.io.FileOutputStream.writeBytes (24 samples)
  • 1.25% com.codename1.tools.translator.BytecodeMethod.appendMethodC (22 samples)
  • 1.14% com.codename1.tools.translator.Parser.cullMethods (20 samples)
  • 1.08% java.lang.StringBuilder.append (19 samples)
  • 0.74% java.io.FileOutputStream.open0 (13 samples)
  • 0.68% com.codename1.tools.translator.Parser.getClassByName (12 samples)
  • 0.57% java.io.FileInputStream.open0 (10 samples)
  • 0.51% com.codename1.tools.translator.BytecodeMethod.appendCMethodPrefix (9 samples)
  • 0.45% java.util.TreeMap.getEntry (8 samples)
  • 0.40% com.codename1.tools.translator.bytecodes.CustomInvoke.appendExpression (7 samples)

• ⚠️ Coverage report not generated.

Static Analysis

• ✅ SpotBugs: no findings (report was not generated by the build).
• ⚠️ PMD report not generated.
• ⚠️ Checkstyle report not generated.

Generated automatically by the PR CI workflow.

[shai-almog]

iOS screenshot updates

Compared 30 screenshots: 23 matched, 6 updated, 1 missing reference.

• BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: Preview provided by instrumentation.
  Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.

• graphics-draw-arc — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 603x1311.
  Full-resolution PNG saved as graphics-draw-arc.png in workflow artifacts.

• graphics-draw-gradient — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
  Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.

• graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

  
  Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
  Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.

• graphics-draw-string — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
  Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.

• graphics-draw-string-decorated — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
  Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.

• kotlin — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: Preview provided by instrumentation.
  Full-resolution PNG saved as kotlin.png in workflow artifacts.

Benchmark Results

• VM Translation Time: 269 seconds
• Compilation Time: 59 seconds

Detailed Performance Metrics

Metric	Duration
Build Time Statistics
Setup & Unzip	23898 ms
Extract Extensions	13 ms
Google Services Setup	1 ms
Scan Classes	515 ms
Extract Libs	1016 ms
Inject Build Hints	25 ms
Generate Unit Tests	1 ms
Generate Stubs	825 ms
Compile Stubs	1897 ms
Generate Icons	896 ms
Prepare ParparVM	103 ms
ParparVM Execution	159000 ms
Post-VM Setup	144 ms
CocoaPods	4185 ms
Finalize	20 ms
Total Time	192540 msMaven Overhead : 77000 ms
CocoaPods Install (Script)	1000 ms
Simulator Boot (Run)	52000 ms
App Install	67000 ms
App Launch	10000 ms
Test Execution	139000 ms