Add CSSThemeCompiler and fix MutableResource typo with tests by shai-almog · Pull Request #4575 · codenameone/CodenameOne

shai-almog · 2026-02-26T17:41:24Z

Motivation

Provide a lightweight compiler to convert a subset of Codename One CSS into theme properties stored in a mutable resource.
Replace the historical typo class MutableResouce with a correct MutableResource implementation and keep a deprecated, backward-compatible MutableResouce wrapper.
Enable programmatic editing and serialization of resources (IMAGE/DATA/L10N) in non-designer environments and support generating ephemeral mutable images from CSS.

Description

Introduces com.codename1.ui.css.CSSThemeCompiler, which parses a constrained subset of CSS (selectors, declarations, :root constants, @constants) and emits theme properties into a MutableResource, including color/box normalization, var() resolution, border aggregation, and cn1-mutable-image handling.
Adds com.codename1.ui.util.MutableResource as the proper mutable resources class with loading/saving, setters (setImage, setData, setTheme, setL10N), restricted type checks, and deterministic save semantics.
Adds a deprecated wrapper MutableResouce that extends MutableResource to preserve backward compatibility with the previous typo-named API.
Updates and adds unit tests: CSSThemeCompilerTest to validate CSS compilation into themes and generated mutable images, and renames/updates MutableResouceTest -> MutableResourceTest to exercise the mutable resource API and serialization.

Testing

Ran the new unit tests CSSThemeCompilerTest and MutableResourceTest from maven/core-unittests and they passed.
Ran the editable save/load round-trip in MutableResourceTest which successfully saved and reloaded IMAGE/DATA/L10N entries via the Resources reader.
Asserted compilation outcomes in CSSThemeCompilerTest, including theme keys, derived values, generated mutable image presence, and border type, all of which succeeded.

Codex Task

shai-almog · 2026-02-26T17:56:57Z

Android screenshot updates

Compared 32 screenshots: 31 matched, 1 error.

kotlin — comparison error. Comparison error: PNG chunk truncated before CRC while processing: /home/runner/work/_temp/cn1ss-hxcRKB/kotlin.png

No preview available for this screenshot.
Full-resolution PNG saved as kotlin.png in workflow artifacts.

Native Android coverage

📊 Line coverage: 7.30% (3714/50867 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 5.70% (18250/320093), branch 2.74% (853/31113), complexity 3.41% (1014/29746), method 6.01% (833/13858), class 9.83% (180/1831)
- Lowest covered classes
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
  - kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
  - kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
  - kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/712 lines covered)
  - kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
  - kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

TonGalaxy · 2026-02-26T17:58:19Z

ในวันที่ ศ. 27 ก.พ. 2026 00:57 น. Shai Almog ***@***.***> เขียนว่า:

…

*shai-almog* left a comment (codenameone/CodenameOne#4575) <#4575 (comment)> Compared 32 screenshots: 32 matched. Native Android coverage - 📊 *Line coverage:* 7.31% (3716/50867 lines covered) [HTML preview] <https://htmlpreview.github.io/?https://raw.githubusercontent.com/codenameone/CodenameOne/e620ff217c1512b9070dc7b10045f0cb1db154a3/runs/22453934036-1/android-coverage/jacocoAndroidReport/html/index.html> (artifact android-coverage-report, jacocoAndroidReport/html/index.html) - Other counters: instruction 5.71% (18263/320093), branch 2.75% (856/31113), complexity 3.41% (1015/29746), method 6.01% (833/13858), class 9.83% (180/1831) - *Lowest covered classes* - kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered) - kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered) - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered) - kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered) - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered) - kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/712 lines covered) - kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered) - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered) - kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered) - kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered) ✅ Native Android screenshot tests passed. Native Android coverage - 📊 *Line coverage:* 7.31% (3716/50867 lines covered) [HTML preview] <https://htmlpreview.github.io/?https://raw.githubusercontent.com/codenameone/CodenameOne/e620ff217c1512b9070dc7b10045f0cb1db154a3/runs/22453934036-1/android-coverage/jacocoAndroidReport/html/index.html> (artifact android-coverage-report, jacocoAndroidReport/html/index.html) - Other counters: instruction 5.71% (18263/320093), branch 2.75% (856/31113), complexity 3.41% (1015/29746), method 6.01% (833/13858), class 9.83% (180/1831) - *Lowest covered classes* - kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered) - kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered) - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered) - kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered) - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered) - kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/712 lines covered) - kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered) - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered) - kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered) - kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered) — Reply to this email directly, view it on GitHub <#4575 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADJMKZKNEGJUNVAGNKORAA34N4XX7AVCNFSM6AAAAACWA2UPN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSNRYGI2DONBUGE> . You are receiving this because you commented.Message ID: ***@***.***>

github-actions · 2026-02-26T18:22:20Z

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 2312 total, 0 failed, 0 skipped
📊 Line coverage: 53.14% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.ui.Display$EdtException – 0.00%
  - com.codename1.ui.plaf.CSSBorder$LinearGradient – 0.00%
  - com.codename1.util.EasyThread$InQueueRunnable – 0.00%
  - com.codename1.components.FloatingActionButton$ReleaseActionListener – 0.00%
  - com.codename1.io.Oauth2$RefreshTokenActionListener – 0.00%
  - com.codename1.util.EasyThread$RunAndWaitRunnable – 0.00%
  - com.codename1.components.ToastBar$FlushAnimationCallback – 0.00%
  - com.codename1.ui.plaf.CSSBorder$ColorStop – 0.00%
  - com.codename1.ui.ElevationComparator – 0.00%
  - com.codename1.ui.spinner.TimeSpinner3D$MinuteRowFormatter – 0.00%

Static Analysis

SpotBugs [HTML preview] [Download]
- ❌ ByteCodeTranslator: 97 findings (High: 2, Normal: 68, Low: 27)
  - Top findings
    - High: com/codename1/tools/translator/BytecodeMethod.java:559 – Method com.codename1.tools.translator.BytecodeMethod.findWritableFields(Set) seems to be useless (rule: UC_USELESS_VOID_METHOD)
    - High: com/codename1/tools/translator/bytecodes/TryCatch.java:75 – Write to static field com.codename1.tools.translator.bytecodes.TryCatch.hasTryCatch from instance method com.codename1.tools.translator.bytecodes.TryCatch.appendInstruction(StringBuilder, List) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
    - Normal: com/codename1/tools/translator/ByteCodeClass.java:1791 – com.codename1.tools.translator.ByteCodeClass.getBaseClassObject() may expose internal representation by returning ByteCodeClass.baseClassObject (rule: EI_EXPOSE_REP)
    - …and 94 more
- ❌ android: 412 findings (High: 24, Normal: 196, Low: 192)
  - Top findings
    - High: CodenameOne/src/com/codename1/impl/CodenameOneThread.java:48 – com.codename1.impl.CodenameOneThread.STACK_FRAME_SIZE isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    - High: com/codename1/impl/android/AndroidImplementation.java:1067 – Write to static field com.codename1.impl.android.AndroidImplementation.context from instance method com.codename1.impl.android.AndroidImplementation.setContext(Context) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
    - High: com/codename1/impl/android/AndroidImplementation.java:1268 – com.codename1.impl.android.AndroidImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
    - …and 409 more
- ❌ codenameone-maven-plugin: 477 findings (High: 1, Normal: 313, Low: 163)
  - Top findings
    - High: com/codename1/maven/AbstractCN1Mojo.java:807 – com.codename1.maven.AbstractCN1Mojo.OS isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    - Normal: com/codename1/builders/AndroidGradleBuilder.java:1018 – Dead store to googleServicesJson in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) (rule: DLS_DEAD_LOCAL_STORE)
    - Normal: com/codename1/builders/AndroidGradleBuilder.java:1043 – Possible null pointer dereference in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) due to return value of called method (rule: NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE)
    - …and 474 more
- ❌ core-unittests: 1 findings (Normal: 1)
  - Top findings
    - Normal: CodenameOne/src/com/codename1/ui/util/MutableResource.java:239 – com.codename1.ui.util.MutableResource.saveL10N(DataOutputStream, Hashtable) makes inefficient use of keySet iterator instead of entrySet iterator (rule: WMI_WRONG_MAP_ITERATOR)
- ❌ ios: 125 findings (High: 4, Normal: 75, Low: 46)
  - Top findings
    - High: com/codename1/impl/ios/IOSImplementation.java:1223 – com.codename1.impl.ios.IOSImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
    - High: com/codename1/impl/ios/IOSImplementation.java:128 – com.codename1.impl.ios.IOSImplementation.nativeInstance isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    - High: com/codename1/impl/ios/IOSImplementation.java:214 – Write to static field com.codename1.impl.ios.IOSImplementation.instance from instance method com.codename1.impl.ios.IOSImplementation.init(Object) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
    - …and 122 more
✅ PMD: 0 findings (no issues) [Report archive]
✅ Checkstyle: 0 findings (no issues) [Report archive]

Generated automatically by the PR CI workflow.

shai-almog · 2026-02-26T18:47:50Z

Compared 32 screenshots: 32 matched.
✅ Native iOS screenshot tests passed.

Benchmark Results

VM Translation Time: 325 seconds
Compilation Time: 270 seconds

Detailed Performance Metrics

Metric	Duration
Build Time Statistics
Setup & Unzip	25431 ms
Extract Extensions	21 ms
Google Services Setup	2 ms
Scan Classes	610 ms
Extract Libs	1115 ms
Inject Build Hints	44 ms
Generate Unit Tests	4 ms
Generate Stubs	1014 ms
Compile Stubs	2334 ms
Generate Icons	987 ms
Prepare ParparVM	188 ms
ParparVM Execution	208330 ms
Post-VM Setup	244 ms
CocoaPods	5153 ms
Finalize	19 ms
Total Time	245497 msMaven Overhead : 80000 ms
CocoaPods Install (Script)	2000 ms
Simulator Boot	73000 ms
Simulator Boot (Run)	7000 ms
App Install	16000 ms
App Launch	10000 ms
Test Execution	150000 ms

Refactor CSSThemeCompiler to avoid regex and chained else-if

aa70f84

shai-almog added the codex label Feb 26, 2026 — with ChatGPT Codex Connector

codenameone deleted a comment from TonGalaxy Feb 26, 2026

Fix PMD foreach warnings in CSSThemeCompiler

16f15df

shai-almog merged commit a6e47b5 into master Feb 26, 2026
16 of 17 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CSSThemeCompiler and fix MutableResource typo with tests#4575

Add CSSThemeCompiler and fix MutableResource typo with tests#4575
shai-almog merged 2 commits intomasterfrom
codex/port-css-compiler-to-codename-one-api

shai-almog commented Feb 26, 2026

Uh oh!

shai-almog commented Feb 26, 2026 •

edited

Loading

Uh oh!

TonGalaxy commented Feb 26, 2026 via email

Uh oh!

github-actions bot commented Feb 26, 2026

Uh oh!

shai-almog commented Feb 26, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

shai-almog commented Feb 26, 2026

Motivation

Description

Testing

Uh oh!

shai-almog commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android screenshot updates

Native Android coverage

Uh oh!

TonGalaxy commented Feb 26, 2026 via email

Uh oh!

github-actions bot commented Feb 26, 2026

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Uh oh!

shai-almog commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmark Results

Detailed Performance Metrics

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shai-almog commented Feb 26, 2026 •

edited

Loading

shai-almog commented Feb 26, 2026 •

edited

Loading