iOS: route status-bar taps into CN1 pointer handling#4707
Merged
liannacasper merged 1 commit intomasterfrom Apr 6, 2026
Merged
iOS: route status-bar taps into CN1 pointer handling#4707liannacasper merged 1 commit intomasterfrom
liannacasper merged 1 commit intomasterfrom
Conversation
Contributor
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
Collaborator
|
Compared 35 screenshots: 35 matched. Benchmark Results
Detailed Performance Metrics
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
createStatusBar()logic can trigger scroll-to-top.Description
UIScrollViewDelegateconformance toCodenameOne_GLViewControllerto receive the system status-bar tap callback viascrollViewShouldScrollToTop:.UIScrollViewnamedcn1StatusBarTapProxyinstalled fromviewDidLoadthat hasscrollsToTop = YESand is sized to the view so the system will invoke the delegate on a status-bar tap.scrollViewShouldScrollToTop:to synthesize a top-edge pointer press/release by callingpointerPressedC(...)andpointerReleasedC(...)with coordinates at the top center, and then reset the proxy content offset to avoid visible scrolling.dealloc(respecting non-ARC release conventions) so it survives rotations/layout and doesn't leak.Testing
./scripts/fast-core-unit-smoke.shfollowing repository guidance to validate core unit tests, but the script failed in this environment because the Java 8 toolchain was not available (JAVA_HOMEnot configured to a Java 8 runtime), so no tests executed.Codex Task