Fix ToastBar empty space above text when positioned at TOP by Copilot · Pull Request #4721 · codenameone/CodenameOne

Copilot · 2026-04-08T01:11:34Z

Explore existing screenshot test patterns in scripts/hellocodenameone
Understand the ToastBar fix and existing regression tests
Create ToastBarTopPositionScreenshotTest.java screenshot test in scripts/hellocodenameone
Register the new test in Cn1ssDeviceRunner.java
Verify core-unittests still pass (14/14 pass)
Run parallel validation

The safe area top padding was unconditionally set to safeArea.getY(), but the layered pane (which wraps the content pane) is already positioned below the toolbar that accounts for the safe area inset. This caused double-counting of the inset, creating empty space above the ToastBar text. Now computes the needed padding as the difference between the safe area top inset and the parent container's absolute Y position, so padding is only added when the ToastBar actually extends into the unsafe area. Agent-Logs-Url: https://github.com/codenameone/CodenameOne/sessions/c374fa90-ccba-426b-b2d3-5e2f430bf1fe Co-authored-by: shai-almog <67850168+shai-almog@users.noreply.github.com>

…culation Agent-Logs-Url: https://github.com/codenameone/CodenameOne/sessions/c374fa90-ccba-426b-b2d3-5e2f430bf1fe Co-authored-by: shai-almog <67850168+shai-almog@users.noreply.github.com>

Add five regression tests to ToastBarTest covering: - TOP position with safe area inset when parent is below safe area (the original bug: should not double-count the inset) - TOP position without safe area inset (no extra padding) - BOTTOM position with safe area bottom inset (correct padding) - BOTTOM position without safe area inset (no extra padding) - TOP position with parent at Y=0 using FormLayeredPane (full safe area padding needed) Also adds setDisplaySafeArea/getDisplaySafeArea to TestCodenameOneImplementation to simulate devices with notches. Agent-Logs-Url: https://github.com/codenameone/CodenameOne/sessions/d40eb36c-4528-4297-97d4-4f8144175502 Co-authored-by: shai-almog <67850168+shai-almog@users.noreply.github.com>

…ber with constant Agent-Logs-Url: https://github.com/codenameone/CodenameOne/sessions/d40eb36c-4528-4297-97d4-4f8144175502 Co-authored-by: shai-almog <67850168+shai-almog@users.noreply.github.com>

github-actions · 2026-04-08T01:21:14Z

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 2369 total, 0 failed, 0 skipped
📊 Line coverage: 53.32% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.ui.Display$EdtException – 0.00%
  - com.codename1.ui.plaf.CSSBorder$LinearGradient – 0.00%
  - com.codename1.util.EasyThread$InQueueRunnable – 0.00%
  - com.codename1.components.FloatingActionButton$ReleaseActionListener – 0.00%
  - com.codename1.io.Oauth2$ShowAuthenticationActionListener – 0.00%
  - com.codename1.io.Oauth2$RefreshTokenActionListener – 0.00%
  - com.codename1.util.EasyThread$RunAndWaitRunnable – 0.00%
  - com.codename1.components.ToastBar$FlushAnimationCallback – 0.00%
  - com.codename1.ui.plaf.CSSBorder$ColorStop – 0.00%
  - com.codename1.ui.ElevationComparator – 0.00%

Static Analysis

SpotBugs [HTML preview] [Download]
- ❌ ByteCodeTranslator: 109 findings (High: 2, Normal: 80, Low: 27)
  - Top findings
    - High: com/codename1/tools/translator/BytecodeMethod.java:559 – Method com.codename1.tools.translator.BytecodeMethod.findWritableFields(Set) seems to be useless (rule: UC_USELESS_VOID_METHOD)
    - High: com/codename1/tools/translator/bytecodes/TryCatch.java:91 – Write to static field com.codename1.tools.translator.bytecodes.TryCatch.hasTryCatch from instance method com.codename1.tools.translator.bytecodes.TryCatch.appendInstruction(StringBuilder, List) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
    - Normal: com/codename1/tools/translator/ByteCodeClass.java:1802 – com.codename1.tools.translator.ByteCodeClass.getBaseClassObject() may expose internal representation by returning ByteCodeClass.baseClassObject (rule: EI_EXPOSE_REP)
    - …and 106 more
- ❌ android: 414 findings (High: 24, Normal: 196, Low: 194)
  - Top findings
    - High: CodenameOne/src/com/codename1/impl/CodenameOneThread.java:48 – com.codename1.impl.CodenameOneThread.STACK_FRAME_SIZE isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    - High: com/codename1/impl/android/AndroidImplementation.java:1085 – Write to static field com.codename1.impl.android.AndroidImplementation.context from instance method com.codename1.impl.android.AndroidImplementation.setContext(Context) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
    - High: com/codename1/impl/android/AndroidImplementation.java:1286 – com.codename1.impl.android.AndroidImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
    - …and 411 more
- ❌ codenameone-maven-plugin: 488 findings (High: 1, Normal: 315, Low: 172)
  - Top findings
    - High: com/codename1/maven/AbstractCN1Mojo.java:807 – com.codename1.maven.AbstractCN1Mojo.OS isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    - Normal: com/codename1/builders/AndroidGradleBuilder.java:1018 – Dead store to googleServicesJson in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) (rule: DLS_DEAD_LOCAL_STORE)
    - Normal: com/codename1/builders/AndroidGradleBuilder.java:1043 – Possible null pointer dereference in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) due to return value of called method (rule: NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE)
    - …and 485 more
- ❌ core-unittests: 1 findings (Normal: 1)
  - Top findings
    - Normal: CodenameOne/src/com/codename1/ui/util/MutableResource.java:239 – com.codename1.ui.util.MutableResource.saveL10N(DataOutputStream, Hashtable) makes inefficient use of keySet iterator instead of entrySet iterator (rule: WMI_WRONG_MAP_ITERATOR)
- ❌ ios: 125 findings (High: 4, Normal: 75, Low: 46)
  - Top findings
    - High: com/codename1/impl/ios/IOSImplementation.java:1228 – com.codename1.impl.ios.IOSImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
    - High: com/codename1/impl/ios/IOSImplementation.java:128 – com.codename1.impl.ios.IOSImplementation.nativeInstance isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    - High: com/codename1/impl/ios/IOSImplementation.java:214 – Write to static field com.codename1.impl.ios.IOSImplementation.instance from instance method com.codename1.impl.ios.IOSImplementation.init(Object) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
    - …and 122 more
✅ PMD: 0 findings (no issues) [Report archive]
✅ Checkstyle: 0 findings (no issues) [Report archive]

Generated automatically by the PR CI workflow.

shai-almog · 2026-04-08T01:25:28Z

Compared 36 screenshots: 36 matched.

Native Android coverage

📊 Line coverage: 7.94% (4066/51218 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 6.25% (20109/321673), branch 2.97% (928/31205), complexity 3.71% (1109/29859), method 6.51% (907/13925), class 10.65% (197/1849)
- Lowest covered classes
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
  - kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
  - kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
  - kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/712 lines covered)
  - kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
  - kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

📊 Line coverage: 7.94% (4066/51218 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 6.25% (20109/321673), branch 2.97% (928/31205), complexity 3.71% (1109/29859), method 6.51% (907/13925), class 10.65% (197/1849)
- Lowest covered classes
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
  - kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
  - kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
  - kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/712 lines covered)
  - kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
  - kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

Benchmark Results

Detailed Performance Metrics

Metric	Duration
Base64 payload size	8192 bytes
Base64 benchmark iterations	6000
Base64 native encode	1175.000 ms
Base64 CN1 encode	218.000 ms
Base64 encode ratio (CN1/native)	0.186x (81.4% faster)
Base64 native decode	1279.000 ms
Base64 CN1 decode	428.000 ms
Base64 decode ratio (CN1/native)	0.335x (66.5% faster)

shai-almog · 2026-04-08T01:34:09Z

iOS screenshot updates

Compared 36 screenshots: 35 matched, 1 updated.

BrowserComponent — updated screenshot. Screenshot differs (1179x2556 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.

Benchmark Results

VM Translation Time: 0 seconds
Compilation Time: 99 seconds

Detailed Performance Metrics

Metric	Duration
Simulator Boot	0 ms
Simulator Boot (Run)	1000 ms
App Install	3000 ms
App Launch	4000 ms
Test Execution	180000 ms
Base64 payload size	8192 bytes
Base64 benchmark iterations	6000
Base64 native encode	1491.000 ms
Base64 CN1 encode	2621.000 ms
Base64 encode ratio (CN1/native)	1.758x (75.8% slower)
Base64 native decode	1006.000 ms
Base64 CN1 decode	2151.000 ms
Base64 decode ratio (CN1/native)	2.138x (113.8% slower)

Add ToastBarTopPositionScreenshotTest that shows a ToastBar message at the TOP position to visually verify no spurious empty space appears above the toast text. Register it in Cn1ssDeviceRunner. Agent-Logs-Url: https://github.com/codenameone/CodenameOne/sessions/eaa2d20f-fd1b-44cd-b3b8-fda8d8155d7a Co-authored-by: shai-almog <67850168+shai-almog@users.noreply.github.com>

Signed-off-by: Shai Almog <67850168+shai-almog@users.noreply.github.com>

Copilot AI and others added 4 commits April 8, 2026 00:53

Skip safe area top padding when parent is null to avoid incorrect cal…

6ef6b8a

…culation Agent-Logs-Url: https://github.com/codenameone/CodenameOne/sessions/c374fa90-ccba-426b-b2d3-5e2f430bf1fe Co-authored-by: shai-almog <67850168+shai-almog@users.noreply.github.com>

Address review feedback: extract cleanup helper and replace magic num…

a54037f

…ber with constant Agent-Logs-Url: https://github.com/codenameone/CodenameOne/sessions/d40eb36c-4528-4297-97d4-4f8144175502 Co-authored-by: shai-almog <67850168+shai-almog@users.noreply.github.com>

Copilot AI assigned Copilot and shai-almog Apr 8, 2026

Copilot created this pull request from a session on behalf of shai-almog April 8, 2026 01:11 View session

shai-almog marked this pull request as ready for review April 8, 2026 01:11

Copilot started work on behalf of shai-almog April 8, 2026 03:45 View session

Copilot AI requested a review from shai-almog April 8, 2026 03:51

Copilot finished work on behalf of shai-almog April 8, 2026 03:51

shai-almog linked an issue Apr 8, 2026 that may be closed by this pull request

Incorrect top padding for ToastBar when shown using Component.TOP (since recent update) #4720

Closed

shai-almog added 2 commits April 8, 2026 07:34

Add files via upload

09f750f

Signed-off-by: Shai Almog <67850168+shai-almog@users.noreply.github.com>

Add files via upload

42aceed

Signed-off-by: Shai Almog <67850168+shai-almog@users.noreply.github.com>

shai-almog merged commit 64b9c78 into master Apr 8, 2026
19 of 20 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix ToastBar empty space above text when positioned at TOP#4721

Fix ToastBar empty space above text when positioned at TOP#4721
shai-almog merged 7 commits intomasterfrom
copilot/fix-toastbar-top-position-issue

Copilot AI commented Apr 8, 2026 •

edited by shai-almog

Loading

Uh oh!

github-actions bot commented Apr 8, 2026 •

edited

Loading

Uh oh!

shai-almog commented Apr 8, 2026 •

edited

Loading

Uh oh!

shai-almog commented Apr 8, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Copilot AI commented Apr 8, 2026 • edited by shai-almog Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Uh oh!

shai-almog commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Native Android coverage

Native Android coverage

Benchmark Results

Detailed Performance Metrics

Uh oh!

shai-almog commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS screenshot updates

Benchmark Results

Detailed Performance Metrics

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Apr 8, 2026 •

edited by shai-almog

Loading

github-actions bot commented Apr 8, 2026 •

edited

Loading

shai-almog commented Apr 8, 2026 •

edited

Loading

shai-almog commented Apr 8, 2026 •

edited

Loading