Add lightweight picker quick-action buttons#4734
Merged
liannacasper merged 7 commits intomasterfrom Apr 11, 2026
Merged
Conversation
Contributor
|
Developer Guide build artifacts are available for download from this workflow run:
Developer Guide quality checks:
Unused image preview:
|
Contributor
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
Collaborator
|
Compared 37 screenshots: 37 matched. Native Android coverage
✅ Native Android screenshot tests passed. Native Android coverage
Benchmark ResultsDetailed Performance Metrics
|
Collaborator
|
Compared 37 screenshots: 37 matched. Benchmark Results
Detailed Performance Metrics
|
Signed-off-by: liannacasper <67953602+liannacasper@users.noreply.github.com>
Signed-off-by: liannacasper <67953602+liannacasper@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Pickerpopup so users can perform common actions like setting a date to “Today” or “+7 Days” without scrolling the wheels.Description
Picker:addLightweightPopupButton(String, Runnable),addLightweightPopupButton(String, Runnable, int),clearLightweightPopupButtons(), andgetLightweightPopupButtonLabels()inCodenameOne/src/com/codename1/ui/spinner/Picker.java.LightweightPopupButtonPlacementconstants (BETWEEN_CANCEL_AND_DONE,ABOVE_SPINNER,BELOW_SPINNER) and a privateLightweightPopupButtonholder class to track label, action and placement.updateValue().maven/core-unittests/src/test/java/com/codename1/ui/spinner/PickerCoverageTest.javato verify custom-button rendering, action behavior, and placement; added a screenshot testLightweightPickerButtonsScreenshotTestinscripts/hellocodenameoneand registered it in the runner; updated developer guide docs with a usage example.Testing
cd maven && mvn -pl core-unittests -am -DfailIfNoTests=false -DunitTests=true -Dmaven.javadoc.skip=true -Dtest=PickerCoverageTest test, andPickerCoverageTestpassed (Tests run: 9, Failures: 0, Errors: 0) and the reactor completed successfully.LightweightPickerButtonsScreenshotTestand attempted to compile the hellocodenameone test harness withcd scripts/hellocodenameone && ./mvnw -pl common -DskipTests compile, but the wrapper failed to fetch dependencies in this environment due to network/socket errors (so the screenshot step was not executed here).Codex Task