Fixed developer guide warnings from vale and cleaned up

[shai-almog]

No description provided.

[github-actions]

Developer Guide build artifacts are available for download from this workflow run:

• Developer Guide HTML package
• Developer Guide PDF
• AsciiDoc linter report
• Vale report
• Unused image report

Developer Guide quality checks:

• AsciiDoc linter: No issues found (report)
• Vale: 14780 alert(s) (1053 errors, 4379 warnings, 9348 suggestions) (exit code 1) (report)
• Image references: No unused images detected (report)

[github-actions]

✅ Continuous Quality Report

Test & Coverage

• ✅ Tests: 2376 total, 0 failed, 0 skipped
• 📊 Line coverage: 53.42% [HTML preview] [Download]
  • Lowest covered classes
    • com.codename1.ui.Display$EdtException – 0.00%
    • com.codename1.ui.plaf.CSSBorder$LinearGradient – 0.00%
    • com.codename1.util.EasyThread$InQueueRunnable – 0.00%
    • com.codename1.components.FloatingActionButton$ReleaseActionListener – 0.00%
    • com.codename1.io.Oauth2$ShowAuthenticationActionListener – 0.00%
    • com.codename1.io.Oauth2$RefreshTokenActionListener – 0.00%
    • com.codename1.util.EasyThread$RunAndWaitRunnable – 0.00%
    • com.codename1.components.ToastBar$FlushAnimationCallback – 0.00%
    • com.codename1.ui.plaf.CSSBorder$ColorStop – 0.00%
    • com.codename1.ui.ElevationComparator – 0.00%

Static Analysis

• SpotBugs [HTML preview] [Download]
  • ❌ ByteCodeTranslator: 110 findings (High: 2, Normal: 81, Low: 27)
    • Top findings
      • High: com/codename1/tools/translator/BytecodeMethod.java:647 – Method com.codename1.tools.translator.BytecodeMethod.findWritableFields(Set) seems to be useless (rule: UC_USELESS_VOID_METHOD)
      • High: com/codename1/tools/translator/bytecodes/TryCatch.java:91 – Write to static field com.codename1.tools.translator.bytecodes.TryCatch.hasTryCatch from instance method com.codename1.tools.translator.bytecodes.TryCatch.appendInstruction(StringBuilder, List) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
      • Normal: com/codename1/tools/translator/ByteCodeClass.java:1802 – com.codename1.tools.translator.ByteCodeClass.getBaseClassObject() may expose internal representation by returning ByteCodeClass.baseClassObject (rule: EI_EXPOSE_REP)
      • …and 107 more
  • ❌ android: 414 findings (High: 24, Normal: 196, Low: 194)
    • Top findings
      • High: CodenameOne/src/com/codename1/impl/CodenameOneThread.java:48 – com.codename1.impl.CodenameOneThread.STACK_FRAME_SIZE isn't final but should be (rule: MS_SHOULD_BE_FINAL)
      • High: com/codename1/impl/android/AndroidImplementation.java:1085 – Write to static field com.codename1.impl.android.AndroidImplementation.context from instance method com.codename1.impl.android.AndroidImplementation.setContext(Context) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
      • High: com/codename1/impl/android/AndroidImplementation.java:1286 – com.codename1.impl.android.AndroidImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
      • …and 411 more
  • ❌ codenameone-maven-plugin: 496 findings (High: 1, Normal: 319, Low: 176)
    • Top findings
      • High: com/codename1/maven/AbstractCN1Mojo.java:807 – com.codename1.maven.AbstractCN1Mojo.OS isn't final but should be (rule: MS_SHOULD_BE_FINAL)
      • Normal: com/codename1/builders/AndroidGradleBuilder.java:1020 – Dead store to googleServicesJson in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) (rule: DLS_DEAD_LOCAL_STORE)
      • Normal: com/codename1/builders/AndroidGradleBuilder.java:1045 – Possible null pointer dereference in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) due to return value of called method (rule: NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE)
      • …and 493 more
  • ❌ core-unittests: 1 findings (Normal: 1)
    • Top findings
      • Normal: CodenameOne/src/com/codename1/ui/util/MutableResource.java:239 – com.codename1.ui.util.MutableResource.saveL10N(DataOutputStream, Hashtable) makes inefficient use of keySet iterator instead of entrySet iterator (rule: WMI_WRONG_MAP_ITERATOR)
  • ❌ ios: 125 findings (High: 4, Normal: 75, Low: 46)
    • Top findings
      • High: com/codename1/impl/ios/IOSImplementation.java:1228 – com.codename1.impl.ios.IOSImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
      • High: com/codename1/impl/ios/IOSImplementation.java:128 – com.codename1.impl.ios.IOSImplementation.nativeInstance isn't final but should be (rule: MS_SHOULD_BE_FINAL)
      • High: com/codename1/impl/ios/IOSImplementation.java:214 – Write to static field com.codename1.impl.ios.IOSImplementation.instance from instance method com.codename1.impl.ios.IOSImplementation.init(Object) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
      • …and 122 more
• ✅ PMD: 0 findings (no issues) [Report archive]
• ✅ Checkstyle: 0 findings (no issues) [Report archive]

Generated automatically by the PR CI workflow.

[Copilot]

Pull request overview

This PR adds a reusable “developer-guide-vale” skill to run Vale locally in a CI-matching way, and applies a broad set of copy/style edits across the Developer Guide to address lint warnings (Vale/AsciiDoc) and improve consistency.

Changes:

• Added a Vale-running skill (commands + agent metadata) that mirrors .github/workflows/developer-guide-docs.yml.
• Updated many Developer Guide chapters to adjust wording, punctuation, and formatting aimed at reducing Vale alerts.
• Performed additional editorial cleanup across Maven appendix/goal docs and other guide sections.

Reviewed changes

Copilot reviewed 46 out of 55 changed files in this pull request and generated 19 comments.

Show a summary per file

File	Description
skills/developer-guide-vale/SKILL.md	Documents CI-matching Vale install/sync/run + report generation steps.
skills/developer-guide-vale/agents/openai.yaml	Registers the skill for the OpenAI agent interface.
docs/developer-guide/Working-with-UWP.asciidoc	Minor wording updates about UWP deprecation.
docs/developer-guide/Working-With-The-GUI-Builder.asciidoc	Editorial changes to GUI Builder troubleshooting and guidance text.
docs/developer-guide/Working-with-Mac-OS-X.asciidoc	Editorial and formatting updates to Mac desktop signing/bundling docs.
docs/developer-guide/Working-With-iOS.asciidoc	Wording updates across troubleshooting, launch screen, CocoaPods/SPM sections.
docs/developer-guide/Working-With-CodenameOne-Sources.asciidoc	Minor copy edits to prerequisites and next steps.
docs/developer-guide/Video-Capture-Constraints.asciidoc	Punctuation/formatting cleanup and table formatting changes.
docs/developer-guide/Theme-Basics.asciidoc	Broad editorial updates to theme basics/tutorial narrative.
docs/developer-guide/The-EDT---Event-Dispatch-Thread.asciidoc	Wording tweaks around EDT usage and helper methods.
docs/developer-guide/signing.asciidoc	Copy edits in iOS/Android signing explanations and wizard steps.
docs/developer-guide/security.asciidoc	Copy edits and phrasing adjustments in security guidance.
docs/developer-guide/performance.asciidoc	Copy edits and small updates in performance guidance and ParparVM hints.
docs/developer-guide/Maven-Updating-Codename-One.adoc	Minor copy edits for update guidance.
docs/developer-guide/Maven-Project-Templates.adoc	Editorial tweaks for template creation instructions.
docs/developer-guide/Maven-Getting-Started.adoc	Editorial tweaks in getting started and migration instructions.
docs/developer-guide/Maven-Creating-CN1Libs.adoc	Copy edits and formatting tweaks in CN1Lib creation docs.
docs/developer-guide/Maven-Appendix-Rich-Properties.adoc	Minor wording cleanup in RPF format appendix.
docs/developer-guide/Maven-Appendix-Control-Center.adoc	Minor wording cleanup in Control Center appendix.
docs/developer-guide/Maven-Appendix-Archetypes.adoc	Minor wording cleanup in archetypes appendix.
docs/developer-guide/Maven-Appendix-API.adoc	Copy edits in API appendix (Java SE wording, notes).
docs/developer-guide/Events.asciidoc	Editorial changes to event system explanations/headings.
docs/developer-guide/component-selector.asciidoc	Copy edits and formatting tweaks in ComponentSelector guide.
docs/developer-guide/Casual-Game-Programming.asciidoc	Editorial changes to narrative voice and punctuation.
docs/developer-guide/appendix_goal-cn1lib.adoc	Minor copy edits for cn1lib goal appendix entry.
docs/developer-guide/appendix_goal_update.adoc	Minor copy edits for update goal appendix entry.
docs/developer-guide/appendix_goal_test.adoc	Minor copy edits for test goal appendix entry.
docs/developer-guide/appendix_goal_prepare_simulator_classpath.adoc	Minor copy edits (Java SE module naming).
docs/developer-guide/appendix_goal_install_codenameone.adoc	Minor copy edits for install-codenameone goal entry.
docs/developer-guide/appendix_goal_install_cn1lib.adoc	Minor copy edits for install-cn1lib goal entry.
docs/developer-guide/appendix_goal_guibuilder.adoc	Minor copy edits for guibuilder goal entry.
docs/developer-guide/appendix_goal_generate_native_interfaces.adoc	Minor copy edits + Java SE module path naming.
docs/developer-guide/appendix_goal_generate_gui_sources.adoc	Minor copy edits for generate-gui-sources goal entry.
docs/developer-guide/appendix_goal_generate_desktop_app_wrapper.adoc	Minor copy edits + Java SE naming.
docs/developer-guide/appendix_goal_generate_cn1lib_project.adoc	Minor copy edits in Ant→Maven cn1lib migration goal entry.
docs/developer-guide/appendix_goal_generate_archetype.adoc	Copy edits and formatting changes in unused goal appendix entry.
docs/developer-guide/appendix_goal_generate_app_project.adoc	Copy edits and clarifications in generate-app-project entry.
docs/developer-guide/appendix_goal_css.adoc	Minor copy edit for css goal entry.
docs/developer-guide/appendix_goal_create_gui_form.adoc	Minor copy edits in create-gui-form goal entry.
docs/developer-guide/appendix_goal_clone.adoc	Minor copy edits for clone goal entry.
docs/developer-guide/appendix_goal_build.adoc	Copy edits + Java SE/Gradle wording changes in build goal entry.
docs/developer-guide/Animations.asciidoc	Copy edits and wording adjustments in animations chapter.
docs/developer-guide/About-This-Guide.asciidoc	Editorial updates to contribution/licensing/conventions preface.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.