Fix concrete invoke dependency resolution when method context is null

[liannacasper]

Motivation

• Dependency collection could run without a method context, and resolveConcreteInvokeOwner() previously bail/returned null when getMethod() was unavailable which caused concrete-class header/includes to be skipped and later produced calls to targets without declarations.

Description

• Stop requiring getMethod() to be non-null in Invoke.resolveConcreteInvokeOwner() and CustomInvoke.resolveConcreteInvokeOwner() so concrete-owner resolution can run during dependency analysis even when no method context exists.
• Make the currentClass lookup null-safe and keep the self/inner-class guard only when currentClass is present.
• Changes touch vm/ByteCodeTranslator/src/com/codename1/tools/translator/bytecodes/Invoke.java and .../CustomInvoke.java with small, equivalent edits in both files.

Testing

• Ran mvn -f vm/ByteCodeTranslator/pom.xml -DskipTests compile which succeeded.
• Attempted the Java 8 setup export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 && export PATH="$JAVA_HOME/bin:$PATH" && mvn -f vm/ByteCodeTranslator/pom.xml -DskipTests compile but that failed because the documented Java 8 path is not available in this environment.

---

Codex Task

[github-actions]

✅ Continuous Quality Report

Test & Coverage

• ✅ Tests: 2379 total, 0 failed, 0 skipped
• 📊 Line coverage: 53.45% [HTML preview] [Download]
  • Lowest covered classes
    • com.codename1.ui.Display$EdtException – 0.00%
    • com.codename1.ui.plaf.CSSBorder$LinearGradient – 0.00%
    • com.codename1.util.EasyThread$InQueueRunnable – 0.00%
    • com.codename1.components.FloatingActionButton$ReleaseActionListener – 0.00%
    • com.codename1.io.Oauth2$ShowAuthenticationActionListener – 0.00%
    • com.codename1.io.Oauth2$RefreshTokenActionListener – 0.00%
    • com.codename1.util.EasyThread$RunAndWaitRunnable – 0.00%
    • com.codename1.components.ToastBar$FlushAnimationCallback – 0.00%
    • com.codename1.ui.plaf.CSSBorder$ColorStop – 0.00%
    • com.codename1.ui.ElevationComparator – 0.00%

Static Analysis

• SpotBugs [HTML preview] [Download]
  • ❌ ByteCodeTranslator: 110 findings (High: 2, Normal: 81, Low: 27)
    • Top findings
      • High: com/codename1/tools/translator/BytecodeMethod.java:647 – Method com.codename1.tools.translator.BytecodeMethod.findWritableFields(Set) seems to be useless (rule: UC_USELESS_VOID_METHOD)
      • High: com/codename1/tools/translator/bytecodes/TryCatch.java:91 – Write to static field com.codename1.tools.translator.bytecodes.TryCatch.hasTryCatch from instance method com.codename1.tools.translator.bytecodes.TryCatch.appendInstruction(StringBuilder, List) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
      • Normal: com/codename1/tools/translator/ByteCodeClass.java:1808 – com.codename1.tools.translator.ByteCodeClass.getBaseClassObject() may expose internal representation by returning ByteCodeClass.baseClassObject (rule: EI_EXPOSE_REP)
      • …and 107 more
  • ❌ android: 414 findings (High: 24, Normal: 196, Low: 194)
    • Top findings
      • High: CodenameOne/src/com/codename1/impl/CodenameOneThread.java:48 – com.codename1.impl.CodenameOneThread.STACK_FRAME_SIZE isn't final but should be (rule: MS_SHOULD_BE_FINAL)
      • High: com/codename1/impl/android/AndroidImplementation.java:1085 – Write to static field com.codename1.impl.android.AndroidImplementation.context from instance method com.codename1.impl.android.AndroidImplementation.setContext(Context) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
      • High: com/codename1/impl/android/AndroidImplementation.java:1286 – com.codename1.impl.android.AndroidImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
      • …and 411 more
  • ❌ codenameone-maven-plugin: 496 findings (High: 1, Normal: 319, Low: 176)
    • Top findings
      • High: com/codename1/maven/AbstractCN1Mojo.java:807 – com.codename1.maven.AbstractCN1Mojo.OS isn't final but should be (rule: MS_SHOULD_BE_FINAL)
      • Normal: com/codename1/builders/AndroidGradleBuilder.java:1020 – Dead store to googleServicesJson in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) (rule: DLS_DEAD_LOCAL_STORE)
      • Normal: com/codename1/builders/AndroidGradleBuilder.java:1045 – Possible null pointer dereference in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) due to return value of called method (rule: NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE)
      • …and 493 more
  • ❌ core-unittests: 1 findings (Normal: 1)
    • Top findings
      • Normal: CodenameOne/src/com/codename1/ui/util/MutableResource.java:239 – com.codename1.ui.util.MutableResource.saveL10N(DataOutputStream, Hashtable) makes inefficient use of keySet iterator instead of entrySet iterator (rule: WMI_WRONG_MAP_ITERATOR)
  • ❌ ios: 125 findings (High: 4, Normal: 75, Low: 46)
    • Top findings
      • High: com/codename1/impl/ios/IOSImplementation.java:1228 – com.codename1.impl.ios.IOSImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
      • High: com/codename1/impl/ios/IOSImplementation.java:128 – com.codename1.impl.ios.IOSImplementation.nativeInstance isn't final but should be (rule: MS_SHOULD_BE_FINAL)
      • High: com/codename1/impl/ios/IOSImplementation.java:214 – Write to static field com.codename1.impl.ios.IOSImplementation.instance from instance method com.codename1.impl.ios.IOSImplementation.init(Object) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
      • …and 122 more
• ✅ PMD: 0 findings (no issues) [Report archive]
• ✅ Checkstyle: 0 findings (no issues) [Report archive]

Generated automatically by the PR CI workflow.

[github-actions]

✅ ByteCodeTranslator Quality Report

Test & Coverage

• ✅ Tests: 381 total, 0 failed, 2 skipped

Benchmark Results

• Execution Time: 10302 ms

• Hotspots (Top 20 sampled methods):

  • 26.55% java.util.ArrayList.indexOf (488 samples)
  • 23.72% java.lang.String.indexOf (436 samples)
  • 19.80% com.codename1.tools.translator.Parser.isMethodUsed (364 samples)
  • 3.70% java.lang.Object.hashCode (68 samples)
  • 2.50% java.lang.System.identityHashCode (46 samples)
  • 1.52% com.codename1.tools.translator.ByteCodeClass.calcUsedByNative (28 samples)
  • 1.36% com.codename1.tools.translator.BytecodeMethod.optimize (25 samples)
  • 1.14% com.codename1.tools.translator.BytecodeMethod.appendCMethodPrefix (21 samples)
  • 0.82% com.codename1.tools.translator.Parser.cullMethods (15 samples)
  • 0.76% com.codename1.tools.translator.ByteCodeClass.markDependent (14 samples)
  • 0.76% com.codename1.tools.translator.Parser.getClassByName (14 samples)
  • 0.76% com.codename1.tools.translator.BytecodeMethod.isMethodUsedByNative (14 samples)
  • 0.65% java.lang.StringBuilder.append (12 samples)
  • 0.60% java.lang.Integer.getChars (11 samples)
  • 0.60% com.codename1.tools.translator.BytecodeMethod.addToConstantPool (11 samples)
  • 0.60% com.codename1.tools.translator.bytecodes.Invoke.addDependencies (11 samples)
  • 0.60% java.lang.StringCoding.encode (11 samples)
  • 0.54% com.codename1.tools.translator.Parser.generateClassAndMethodIndexHeader (10 samples)
  • 0.49% com.codename1.tools.translator.BytecodeMethod.appendMethodSignatureSuffixFromDesc (9 samples)
  • 0.49% com.codename1.tools.translator.ByteCodeClass.markDependencies (9 samples)

• ⚠️ Coverage report not generated.

Static Analysis

• ✅ SpotBugs: no findings (report was not generated by the build).
• ⚠️ PMD report not generated.
• ⚠️ Checkstyle report not generated.

Generated automatically by the PR CI workflow.

[shai-almog]

Compared 37 screenshots: 37 matched.
✅ Native iOS screenshot tests passed.

Benchmark Results

• VM Translation Time: 0 seconds
• Compilation Time: 114 seconds

Detailed Performance Metrics

Metric	Duration
Simulator Boot	1000 ms
Simulator Boot (Run)	0 ms
App Install	2000 ms
App Launch	3000 ms
Test Execution	170000 ms
Base64 payload size	8192 bytes
Base64 benchmark iterations	6000
Base64 native encode	1962.000 ms
Base64 CN1 encode	2123.000 ms
Base64 encode ratio (CN1/native)	1.082x (8.2% slower)
Base64 native decode	1270.000 ms
Base64 CN1 decode	1316.000 ms
Base64 decode ratio (CN1/native)	1.036x (3.6% slower)