Align cn1playground light/dark theming with design guide tokens#4754
Merged
liannacasper merged 1 commit intomasterfrom Apr 15, 2026
Merged
Conversation
Contributor
Cloudflare Preview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
scripts/cn1playground/common/src/main/css/theme.cssto use the design-guide color tokens and navy-based dark palette across panels, inspector controls, tabs, and previews.scripts/cn1playground/src/html/playground-editor/index.htmlto match the design palette, typography stack, border and inline message colors for both light and dark modes.scripts/cn1playground/src/html/playground-editor/editor.js(cn1-playground-lightandcn1-playground-dark) and wiredapplyTheme()to use them so editor background/foreground/cursor/selection colors follow the design language.Testing
node --check scripts/cn1playground/src/html/playground-editor/editor.jswhich succeeded.git diff --checkwhich reported no whitespace/issues.bash ./scripts/cn1playground/tools/run-playground-smoke-tests.shand it failed during the Maven build due to an unresolved local artifact (com.codenameone.playground:cn1playground-ZipSupport:jar:common:1.0-SNAPSHOT), so the full Maven build could not complete in this environment.Codex Task