Skip to content

Fix Material Icons automation output and PR CI triggering#4761

Merged
shai-almog merged 1 commit intomasterfrom
copilot/update-material-icons-fontimage
Apr 16, 2026
Merged

Fix Material Icons automation output and PR CI triggering#4761
shai-almog merged 1 commit intomasterfrom
copilot/update-material-icons-fontimage

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 16, 2026

The Material Icons Update workflow was generating a broken FontImage.java diff by writing literal \n sequences into doc comments and duplicating the first comment block. The resulting automation PRs also were not picking up the expected PR CI checks.

  • Generator output

    • Replace escaped newline text in the generated material icon doc block with real newlines.
    • Expand replacement boundaries in FontImage.java so regeneration overwrites the leading comment block together with the constants, avoiding duplicated comments on the first constant.
  • Workflow behavior

    • Clarify the schedule in the workflow header: weekly on Monday at 06:00 UTC.
    • Capture the create-pull-request step output and explicitly dispatch pr.yml for the generated automation branch after the PR is created.
    • Add the required actions: write permission for workflow dispatch.
  • PR CI entrypoint

    • Add workflow_dispatch to pr.yml so automation can invoke the same CI workflow that normally runs on pull requests.

Example of the generator fix:

CONSTANT_DOC = (
    "    /// Material design icon font character code see\n"
    "    /// https://www.material.io/resources/icons/ for full list\n"
)

if start_idx is None and CONSTANT_RE.match(line):
    start_idx = i
    while start_idx > 0 and is_material_constant_doc_line(lines[start_idx - 1]):
        start_idx -= 1

Agent-Logs-Url: https://github.com/codenameone/CodenameOne/sessions/09ed0e92-f319-4f2e-8fbc-ff44ed2c1a9e

Co-authored-by: shai-almog <67850168+shai-almog@users.noreply.github.com>
@shai-almog shai-almog marked this pull request as ready for review April 16, 2026 14:50
@shai-almog shai-almog merged commit 7a09587 into master Apr 16, 2026
12 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Generated automatically by the PR CI workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants