Enable UIScene by default by shai-almog · Pull Request #4786 · codenameone/CodenameOne

shai-almog · 2026-04-21T06:44:33Z

Fixes #4731

github-actions · 2026-04-21T06:49:21Z

Developer Guide build artifacts are available for download from this workflow run:

Developer Guide quality checks:

AsciiDoc linter: No issues found (report)
Vale: 15058 alert(s) (1097 errors, 4449 warnings, 9512 suggestions) (exit code 1) (report)
Image references: No unused images detected (report)

github-actions · 2026-04-21T06:52:53Z

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 2398 total, 0 failed, 0 skipped
📊 Line coverage: 53.31% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.ui.Display$EdtException – 0.00%
  - com.codename1.ui.plaf.CSSBorder$LinearGradient – 0.00%
  - com.codename1.util.EasyThread$InQueueRunnable – 0.00%
  - com.codename1.components.FloatingActionButton$ReleaseActionListener – 0.00%
  - com.codename1.io.Oauth2$ShowAuthenticationActionListener – 0.00%
  - com.codename1.io.Oauth2$RefreshTokenActionListener – 0.00%
  - com.codename1.util.EasyThread$RunAndWaitRunnable – 0.00%
  - com.codename1.components.ToastBar$FlushAnimationCallback – 0.00%
  - com.codename1.ui.plaf.CSSBorder$ColorStop – 0.00%
  - com.codename1.ui.ElevationComparator – 0.00%

Static Analysis

SpotBugs [HTML preview] [Download]
- ❌ ByteCodeTranslator: 110 findings (High: 2, Normal: 81, Low: 27)
  - Top findings
    - High: com/codename1/tools/translator/BytecodeMethod.java:647 – Method com.codename1.tools.translator.BytecodeMethod.findWritableFields(Set) seems to be useless (rule: UC_USELESS_VOID_METHOD)
    - High: com/codename1/tools/translator/bytecodes/TryCatch.java:91 – Write to static field com.codename1.tools.translator.bytecodes.TryCatch.hasTryCatch from instance method com.codename1.tools.translator.bytecodes.TryCatch.appendInstruction(StringBuilder, List) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
    - Normal: com/codename1/tools/translator/ByteCodeClass.java:1823 – com.codename1.tools.translator.ByteCodeClass.getBaseClassObject() may expose internal representation by returning ByteCodeClass.baseClassObject (rule: EI_EXPOSE_REP)
    - …and 107 more
- ❌ android: 414 findings (High: 24, Normal: 196, Low: 194)
  - Top findings
    - High: CodenameOne/src/com/codename1/impl/CodenameOneThread.java:48 – com.codename1.impl.CodenameOneThread.STACK_FRAME_SIZE isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    - High: com/codename1/impl/android/AndroidImplementation.java:1156 – Write to static field com.codename1.impl.android.AndroidImplementation.context from instance method com.codename1.impl.android.AndroidImplementation.setContext(Context) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
    - High: com/codename1/impl/android/AndroidImplementation.java:1357 – com.codename1.impl.android.AndroidImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
    - …and 411 more
- ❌ codenameone-maven-plugin: 497 findings (High: 1, Normal: 320, Low: 176)
  - Top findings
    - High: com/codename1/maven/AbstractCN1Mojo.java:807 – com.codename1.maven.AbstractCN1Mojo.OS isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    - Normal: com/codename1/builders/AndroidGradleBuilder.java:1020 – Dead store to googleServicesJson in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) (rule: DLS_DEAD_LOCAL_STORE)
    - Normal: com/codename1/builders/AndroidGradleBuilder.java:1045 – Possible null pointer dereference in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) due to return value of called method (rule: NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE)
    - …and 494 more
- ❌ core-unittests: 1 findings (Normal: 1)
  - Top findings
    - Normal: CodenameOne/src/com/codename1/ui/util/MutableResource.java:239 – com.codename1.ui.util.MutableResource.saveL10N(DataOutputStream, Hashtable) makes inefficient use of keySet iterator instead of entrySet iterator (rule: WMI_WRONG_MAP_ITERATOR)
- ❌ ios: 124 findings (High: 4, Normal: 74, Low: 46)
  - Top findings
    - High: com/codename1/impl/ios/IOSImplementation.java:1229 – com.codename1.impl.ios.IOSImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
    - High: com/codename1/impl/ios/IOSImplementation.java:129 – com.codename1.impl.ios.IOSImplementation.nativeInstance isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    - High: com/codename1/impl/ios/IOSImplementation.java:215 – Write to static field com.codename1.impl.ios.IOSImplementation.instance from instance method com.codename1.impl.ios.IOSImplementation.init(Object) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
    - …and 121 more
✅ PMD: 0 findings (no issues) [Report archive]
❌ Checkstyle: 49 findings (Error: 49) [HTML preview] [Download]
- Top findings
  - Error: CodenameOne/src/com/codename1/util/Simd.java:91:28 – 'typecast' is not followed by whitespace. (rule: WhitespaceAfterCheck)
  - Error: CodenameOne/src/com/codename1/util/Simd.java:169:39 – 'typecast' is not followed by whitespace. (rule: WhitespaceAfterCheck)
  - Error: CodenameOne/src/com/codename1/util/Simd.java:176:39 – 'typecast' is not followed by whitespace. (rule: WhitespaceAfterCheck)
  - Error: CodenameOne/src/com/codename1/util/Simd.java:184:39 – 'typecast' is not followed by whitespace. (rule: WhitespaceAfterCheck)
  - Error: CodenameOne/src/com/codename1/util/Simd.java:192:39 – 'typecast' is not followed by whitespace. (rule: WhitespaceAfterCheck)
  - …and 44 more

Generated automatically by the PR CI workflow.

shai-almog · 2026-04-21T06:58:36Z

Compared 37 screenshots: 37 matched.

Native Android coverage

📊 Line coverage: 7.86% (4161/52962 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 6.17% (20571/333306), branch 3.00% (965/32144), complexity 3.66% (1124/30738), method 6.42% (920/14331), class 10.63% (202/1900)
- Lowest covered classes
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
  - kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
  - kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
  - kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/730 lines covered)
  - kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
  - kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

📊 Line coverage: 7.86% (4161/52962 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 6.17% (20571/333306), branch 3.00% (965/32144), complexity 3.66% (1124/30738), method 6.42% (920/14331), class 10.63% (202/1900)
- Lowest covered classes
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
  - kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
  - kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
  - kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/730 lines covered)
  - kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
  - kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

Benchmark Results

Detailed Performance Metrics

Metric	Duration
Base64 payload size	8192 bytes
Base64 benchmark iterations	6000
Base64 native encode	1053.000 ms
Base64 CN1 encode	131.000 ms
Base64 encode ratio (CN1/native)	0.124x (87.6% faster)
Base64 native decode	584.000 ms
Base64 CN1 decode	344.000 ms
Base64 decode ratio (CN1/native)	0.589x (41.1% faster)
Image encode benchmark status	skipped (SIMD unsupported)

shai-almog · 2026-04-21T11:16:16Z

Compared 37 screenshots: 37 matched.
✅ Native iOS screenshot tests passed.

Benchmark Results

VM Translation Time: 0 seconds
Compilation Time: 136 seconds

Build and Run Timing

Metric	Duration
Simulator Boot	71000 ms
Simulator Boot (Run)	1000 ms
App Install	31000 ms
App Launch	7000 ms
Test Execution	198000 ms

Detailed Performance Metrics

Metric	Duration
Base64 payload size	8192 bytes
Base64 benchmark iterations	6000
Base64 native encode	1637.000 ms
Base64 CN1 encode	2105.000 ms
Base64 encode ratio (CN1/native)	1.286x (28.6% slower)
Base64 native decode	1033.000 ms
Base64 CN1 decode	1426.000 ms
Base64 decode ratio (CN1/native)	1.380x (38.0% slower)
Base64 SIMD encode	619.000 ms
Base64 encode ratio (SIMD/native)	0.378x (62.2% faster)
Base64 encode ratio (SIMD/CN1)	0.294x (70.6% faster)
Base64 SIMD decode	804.000 ms
Base64 decode ratio (SIMD/native)	0.778x (22.2% faster)
Base64 decode ratio (SIMD/CN1)	0.564x (43.6% faster)
Image encode benchmark iterations	100
Image createMask (SIMD off)	60.000 ms
Image createMask (SIMD on)	11.000 ms
Image createMask ratio (SIMD on/off)	0.183x (81.7% faster)
Image applyMask (SIMD off)	246.000 ms
Image applyMask (SIMD on)	81.000 ms
Image applyMask ratio (SIMD on/off)	0.329x (67.1% faster)
Image modifyAlpha (SIMD off)	209.000 ms
Image modifyAlpha (SIMD on)	154.000 ms
Image modifyAlpha ratio (SIMD on/off)	0.737x (26.3% faster)
Image modifyAlpha removeColor (SIMD off)	254.000 ms
Image modifyAlpha removeColor (SIMD on)	94.000 ms
Image modifyAlpha removeColor ratio (SIMD on/off)	0.370x (63.0% faster)
Image PNG encode (SIMD off)	1140.000 ms
Image PNG encode (SIMD on)	947.000 ms
Image PNG encode ratio (SIMD on/off)	0.831x (16.9% faster)
Image JPEG encode	556.000 ms

Enable UIScene by default

8722fc7

Fixes #4731

shai-almog added 2 commits April 21, 2026 11:32

Flipped this back to default false and fixed UIScene bug

61cd262

Fixed UIScene hint

60f0303

shai-almog force-pushed the enable-uiscene-by-default branch from 04f484f to 161324d Compare April 21, 2026 12:39

Additional UIScene fix

1e68331

shai-almog force-pushed the enable-uiscene-by-default branch from 161324d to 1e68331 Compare April 21, 2026 14:35

Re-enabling UIScene by Default

d97113f

shai-almog merged commit c620aa0 into master Apr 21, 2026
23 of 28 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable UIScene by default#4786

Enable UIScene by default#4786
shai-almog merged 5 commits intomasterfrom
enable-uiscene-by-default

shai-almog commented Apr 21, 2026

Uh oh!

github-actions Bot commented Apr 21, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 21, 2026 •

edited

Loading

Uh oh!

shai-almog commented Apr 21, 2026 •

edited

Loading

Uh oh!

shai-almog commented Apr 21, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

shai-almog commented Apr 21, 2026

Uh oh!

github-actions Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Uh oh!

shai-almog commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Native Android coverage

Native Android coverage

Benchmark Results

Detailed Performance Metrics

Uh oh!

shai-almog commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmark Results

Build and Run Timing

Detailed Performance Metrics

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions Bot commented Apr 21, 2026 •

edited

Loading

github-actions Bot commented Apr 21, 2026 •

edited

Loading

shai-almog commented Apr 21, 2026 •

edited

Loading

shai-almog commented Apr 21, 2026 •

edited

Loading