Skip to content

Added additional picker button positioning options#4820

Merged
shai-almog merged 1 commit intomasterfrom
picker-button-positioning
Apr 27, 2026
Merged

Added additional picker button positioning options#4820
shai-almog merged 1 commit intomasterfrom
picker-button-positioning

Conversation

@shai-almog
Copy link
Copy Markdown
Collaborator

@shai-almog shai-almog commented Apr 27, 2026

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 27, 2026

Cloudflare Preview

@shai-almog
Copy link
Copy Markdown
Collaborator Author

shai-almog commented Apr 27, 2026 •
edited
Loading

Compared 65 screenshots: 65 matched.

Native Android coverage

  • 📊 Line coverage: 8.69% (4651/53524 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
    • Other counters: instruction 6.82% (22882/335748), branch 3.26% (1053/32302), complexity 4.05% (1252/30918), method 7.08% (1022/14432), class 11.67% (224/1920)
    • Lowest covered classes
      • kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
      • kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
      • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
      • kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
      • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
      • kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/730 lines covered)
      • kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
      • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
      • kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
      • kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

  • 📊 Line coverage: 8.69% (4651/53524 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
    • Other counters: instruction 6.82% (22882/335748), branch 3.26% (1053/32302), complexity 4.05% (1252/30918), method 7.08% (1022/14432), class 11.67% (224/1920)
    • Lowest covered classes
      • kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
      • kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
      • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
      • kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
      • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
      • kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/730 lines covered)
      • kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
      • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
      • kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
      • kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

Benchmark Results

Detailed Performance Metrics

Metric Duration
Base64 payload size 8192 bytes
Base64 benchmark iterations 6000
Base64 native encode 1218.000 ms
Base64 CN1 encode 275.000 ms
Base64 encode ratio (CN1/native) 0.226x (77.4% faster)
Base64 native decode 1268.000 ms
Base64 CN1 decode 230.000 ms
Base64 decode ratio (CN1/native) 0.181x (81.9% faster)
Image encode benchmark status skipped (SIMD unsupported)

@shai-almog shai-almog force-pushed the picker-button-positioning branch from b92f091 to 82f8b19 Compare April 27, 2026 17:07
@shai-almog shai-almog linked an issue Apr 27, 2026 that may be closed by this pull request
RFE (or UI bug ;-): custom action buttons added to lightweight Pickers are stuck to the left due placed in a BoxLayout.x() #4819
Closed
@shai-almog shai-almog force-pushed the picker-button-positioning branch from 82f8b19 to 1831f2f Compare April 27, 2026 17:26
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 27, 2026

✅ Continuous Quality Report

Test & Coverage

Static Analysis

  • SpotBugs [Report archive]
    • ✅ ByteCodeTranslator: 0 findings (no issues)
    • ✅ android: 0 findings (no issues)
    • ✅ codenameone-maven-plugin: 0 findings (no issues)
    • ✅ core-unittests: 0 findings (no issues)
    • ✅ ios: 0 findings (no issues)
  • ✅ PMD: 0 findings (no issues) [Report archive]
  • ✅ Checkstyle: 0 findings (no issues) [Report archive]

Generated automatically by the PR CI workflow.

@shai-almog
Copy link
Copy Markdown
Collaborator Author

shai-almog commented Apr 27, 2026 •
edited
Loading

iOS screenshot updates

Compared 65 screenshots: 64 matched, 1 updated.

  • landscape — updated screenshot. Screenshot differs (2556x1179 px, bit depth 8).

    landscape
    Preview info: Preview provided by instrumentation.
    Full-resolution PNG saved as landscape.png in workflow artifacts.

Benchmark Results

  • VM Translation Time: 0 seconds
  • Compilation Time: 261 seconds

Build and Run Timing

Metric Duration
Simulator Boot 91000 ms
Simulator Boot (Run) 4000 ms
App Install 15000 ms
App Launch 7000 ms
Test Execution 238000 ms

Detailed Performance Metrics

Metric Duration
Base64 payload size 8192 bytes
Base64 benchmark iterations 6000
Base64 native encode 1168.000 ms
Base64 CN1 encode 1551.000 ms
Base64 encode ratio (CN1/native) 1.328x (32.8% slower)
Base64 native decode 795.000 ms
Base64 CN1 decode 1122.000 ms
Base64 decode ratio (CN1/native) 1.411x (41.1% slower)
Base64 SIMD encode 737.000 ms
Base64 encode ratio (SIMD/native) 0.631x (36.9% faster)
Base64 encode ratio (SIMD/CN1) 0.475x (52.5% faster)
Base64 SIMD decode 530.000 ms
Base64 decode ratio (SIMD/native) 0.667x (33.3% faster)
Base64 decode ratio (SIMD/CN1) 0.472x (52.8% faster)
Image encode benchmark iterations 100
Image createMask (SIMD off) 115.000 ms
Image createMask (SIMD on) 11.000 ms
Image createMask ratio (SIMD on/off) 0.096x (90.4% faster)
Image applyMask (SIMD off) 210.000 ms
Image applyMask (SIMD on) 57.000 ms
Image applyMask ratio (SIMD on/off) 0.271x (72.9% faster)
Image modifyAlpha (SIMD off) 215.000 ms
Image modifyAlpha (SIMD on) 114.000 ms
Image modifyAlpha ratio (SIMD on/off) 0.530x (47.0% faster)
Image modifyAlpha removeColor (SIMD off) 246.000 ms
Image modifyAlpha removeColor (SIMD on) 135.000 ms
Image modifyAlpha removeColor ratio (SIMD on/off) 0.549x (45.1% faster)
Image PNG encode (SIMD off) 1379.000 ms
Image PNG encode (SIMD on) 1088.000 ms
Image PNG encode ratio (SIMD on/off) 0.789x (21.1% faster)
Image JPEG encode 522.000 ms

@shai-almog shai-almog merged commit a838aed into master Apr 27, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RFE (or UI bug ;-): custom action buttons added to lightweight Pickers are stuck to the left due placed in a BoxLayout.x()

1 participant

@shai-almog