Revert "Added theme constants for accents (#4848)" by shai-almog · Pull Request #4877 · codenameone/CodenameOne

shai-almog · 2026-05-07T18:02:05Z

This reverts commit af0309e.

github-actions · 2026-05-07T18:05:55Z

Developer Guide build artifacts are available for download from this workflow run:

Developer Guide quality checks:

AsciiDoc linter: No issues found (report)
Vale: Vale failed (exit code 2) (report)
Image references: 1 unused image(s) found (report)

Unused image preview:

img/skin-designer/.gitkeep

github-actions · 2026-05-07T18:11:02Z

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 2450 total, 0 failed, 0 skipped
📊 Line coverage: 53.47% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.ui.Display$EdtException – 0.00%
  - com.codename1.ui.plaf.CSSBorder$LinearGradient – 0.00%
  - com.codename1.util.EasyThread$InQueueRunnable – 0.00%
  - com.codename1.components.FloatingActionButton$ReleaseActionListener – 0.00%
  - com.codename1.io.Oauth2$ShowAuthenticationActionListener – 0.00%
  - com.codename1.io.Oauth2$RefreshTokenActionListener – 0.00%
  - com.codename1.util.EasyThread$RunAndWaitRunnable – 0.00%
  - com.codename1.components.ToastBar$FlushAnimationCallback – 0.00%
  - com.codename1.ui.plaf.CSSBorder$ColorStop – 0.00%
  - com.codename1.ui.ElevationComparator – 0.00%

Static Analysis

SpotBugs [Report archive]
- ✅ ByteCodeTranslator: 0 findings (no issues)
- ✅ android: 0 findings (no issues)
- ✅ codenameone-maven-plugin: 0 findings (no issues)
- ✅ core-unittests: 0 findings (no issues)
- ✅ ios: 0 findings (no issues)
✅ PMD: 0 findings (no issues) [Report archive]
✅ Checkstyle: 0 findings (no issues) [Report archive]

Generated automatically by the PR CI workflow.

github-actions · 2026-05-07T18:13:43Z

Cloudflare Preview

URL: https://pr-4877-website-preview.codenameone.pages.dev
Branch: pr-4877-website-preview

shai-almog · 2026-05-07T18:25:13Z

Compared 90 screenshots: 90 matched.

Native Android coverage

📊 Line coverage: 10.17% (5550/54579 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 7.99% (27204/340606), branch 3.65% (1193/32646), complexity 4.67% (1460/31272), method 8.21% (1200/14614), class 13.59% (267/1964)
- Lowest covered classes
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
  - kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
  - kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
  - kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/730 lines covered)
  - kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
  - kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

📊 Line coverage: 10.17% (5550/54579 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 7.99% (27204/340606), branch 3.65% (1193/32646), complexity 4.67% (1460/31272), method 8.21% (1200/14614), class 13.59% (267/1964)
- Lowest covered classes
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
  - kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
  - kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
  - kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/730 lines covered)
  - kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
  - kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

Benchmark Results

Detailed Performance Metrics

Metric	Duration
Base64 payload size	8192 bytes
Base64 benchmark iterations	6000
Base64 native encode	935.000 ms
Base64 CN1 encode	213.000 ms
Base64 encode ratio (CN1/native)	0.228x (77.2% faster)
Base64 native decode	1195.000 ms
Base64 CN1 decode	326.000 ms
Base64 decode ratio (CN1/native)	0.273x (72.7% faster)
Image encode benchmark status	skipped (SIMD unsupported)

shai-almog · 2026-05-07T18:42:47Z

Compared 90 screenshots: 90 matched.
✅ Native iOS Metal screenshot tests passed.

Benchmark Results

VM Translation Time: 0 seconds
Compilation Time: 301 seconds

Build and Run Timing

Metric	Duration
Simulator Boot	87000 ms
Simulator Boot (Run)	2000 ms
App Install	17000 ms
App Launch	10000 ms
Test Execution	249000 ms

Detailed Performance Metrics

Metric	Duration
Base64 payload size	8192 bytes
Base64 benchmark iterations	6000
Base64 native encode	1431.000 ms
Base64 CN1 encode	2468.000 ms
Base64 encode ratio (CN1/native)	1.725x (72.5% slower)
Base64 native decode	1190.000 ms
Base64 CN1 decode	1816.000 ms
Base64 decode ratio (CN1/native)	1.526x (52.6% slower)
Base64 SIMD encode	680.000 ms
Base64 encode ratio (SIMD/native)	0.475x (52.5% faster)
Base64 encode ratio (SIMD/CN1)	0.276x (72.4% faster)
Base64 SIMD decode	542.000 ms
Base64 decode ratio (SIMD/native)	0.455x (54.5% faster)
Base64 decode ratio (SIMD/CN1)	0.298x (70.2% faster)
Image encode benchmark iterations	100
Image createMask (SIMD off)	74.000 ms
Image createMask (SIMD on)	14.000 ms
Image createMask ratio (SIMD on/off)	0.189x (81.1% faster)
Image applyMask (SIMD off)	235.000 ms
Image applyMask (SIMD on)	97.000 ms
Image applyMask ratio (SIMD on/off)	0.413x (58.7% faster)
Image modifyAlpha (SIMD off)	299.000 ms
Image modifyAlpha (SIMD on)	90.000 ms
Image modifyAlpha ratio (SIMD on/off)	0.301x (69.9% faster)
Image modifyAlpha removeColor (SIMD off)	308.000 ms
Image modifyAlpha removeColor (SIMD on)	145.000 ms
Image modifyAlpha removeColor ratio (SIMD on/off)	0.471x (52.9% faster)
Image PNG encode (SIMD off)	1882.000 ms
Image PNG encode (SIMD on)	1097.000 ms
Image PNG encode ratio (SIMD on/off)	0.583x (41.7% faster)
Image JPEG encode	954.000 ms

shai-almog · 2026-05-07T18:44:41Z

Compared 90 screenshots: 90 matched.
✅ Native iOS screenshot tests passed.

Benchmark Results

VM Translation Time: 0 seconds
Compilation Time: 335 seconds

Build and Run Timing

Metric	Duration
Simulator Boot	103000 ms
Simulator Boot (Run)	2000 ms
App Install	17000 ms
App Launch	14000 ms
Test Execution	272000 ms

Detailed Performance Metrics

Metric	Duration
Base64 payload size	8192 bytes
Base64 benchmark iterations	6000
Base64 native encode	2177.000 ms
Base64 CN1 encode	2759.000 ms
Base64 encode ratio (CN1/native)	1.267x (26.7% slower)
Base64 native decode	1147.000 ms
Base64 CN1 decode	1599.000 ms
Base64 decode ratio (CN1/native)	1.394x (39.4% slower)
Base64 SIMD encode	917.000 ms
Base64 encode ratio (SIMD/native)	0.421x (57.9% faster)
Base64 encode ratio (SIMD/CN1)	0.332x (66.8% faster)
Base64 SIMD decode	751.000 ms
Base64 decode ratio (SIMD/native)	0.655x (34.5% faster)
Base64 decode ratio (SIMD/CN1)	0.470x (53.0% faster)
Image encode benchmark iterations	100
Image createMask (SIMD off)	263.000 ms
Image createMask (SIMD on)	22.000 ms
Image createMask ratio (SIMD on/off)	0.084x (91.6% faster)
Image applyMask (SIMD off)	502.000 ms
Image applyMask (SIMD on)	54.000 ms
Image applyMask ratio (SIMD on/off)	0.108x (89.2% faster)
Image modifyAlpha (SIMD off)	184.000 ms
Image modifyAlpha (SIMD on)	62.000 ms
Image modifyAlpha ratio (SIMD on/off)	0.337x (66.3% faster)
Image modifyAlpha removeColor (SIMD off)	237.000 ms
Image modifyAlpha removeColor (SIMD on)	255.000 ms
Image modifyAlpha removeColor ratio (SIMD on/off)	1.076x (7.6% slower)
Image PNG encode (SIMD off)	1492.000 ms
Image PNG encode (SIMD on)	1197.000 ms
Image PNG encode ratio (SIMD on/off)	0.802x (19.8% faster)
Image JPEG encode	829.000 ms

Revert "Added theme constants for accents (#4848)"

4641118

This reverts commit af0309e.

shai-almog merged commit fb5e9b9 into master May 7, 2026
20 of 21 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "Added theme constants for accents (#4848)"#4877

Revert "Added theme constants for accents (#4848)"#4877
shai-almog merged 1 commit intomasterfrom
revert-4848

shai-almog commented May 7, 2026

Uh oh!

github-actions Bot commented May 7, 2026

Uh oh!

github-actions Bot commented May 7, 2026

Uh oh!

github-actions Bot commented May 7, 2026

Uh oh!

shai-almog commented May 7, 2026 •

edited

Loading

Uh oh!

shai-almog commented May 7, 2026 •

edited

Loading

Uh oh!

shai-almog commented May 7, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

shai-almog commented May 7, 2026

Uh oh!

github-actions Bot commented May 7, 2026

Uh oh!

github-actions Bot commented May 7, 2026

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Uh oh!

github-actions Bot commented May 7, 2026

Cloudflare Preview

Uh oh!

shai-almog commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Native Android coverage

Native Android coverage

Benchmark Results

Detailed Performance Metrics

Uh oh!

shai-almog commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmark Results

Build and Run Timing

Detailed Performance Metrics

Uh oh!

shai-almog commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmark Results

Build and Run Timing

Detailed Performance Metrics

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

shai-almog commented May 7, 2026 •

edited

Loading

shai-almog commented May 7, 2026 •

edited

Loading

shai-almog commented May 7, 2026 •

edited

Loading