Fix agent tool Codename One version selection#4965
Merged
shai-almog merged 1 commit intoMay 16, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes version discovery in the Codename One agent tools generated by Initializr.
The tools currently sort Maven artifact jar names lexicographically. This can select an older version such as
7.0.26instead of a newer version such as7.0.243, because string ordering does not match semantic/numeric version ordering.This PR changes the sorting logic in:
IsApiSupported.javaIsCssValid.javaThe tools now compare the Maven version directory numerically, so the latest installed Codename One version is selected correctly.
I also fixed
IsCssValid.javato usegetMethod("getTheme", ...)instead ofgetDeclaredMethod(...), becausegetTheme(String)is a public method inherited fromResources, not declared directly onMutableResource.Verification:
IsApiSupportednow selectsjava-runtime/7.0.243correctly.IsCssValidnow selectscodenameone-core/7.0.243andjava-runtime/7.0.243.IsCssValidsuccessfully validates a minimal valid CSS file.