Fix #5024: treat Picker.setDate(null) as an explicit clear by shai-almog · Pull Request #5025 · codenameone/CodenameOne

shai-almog · 2026-05-24T01:43:22Z

Summary

Fixes Picker: doing a setDate(null) then getDate() will return the default value even though the Picker has not been opened and the default value not accepted by the user with Done #5024. setDate(null) on a Picker configured with setDefaultDate(...) no longer silently substitutes the default getter's value through getDate(). After setDate(null), getDate() returns null (and the picker text falls back to the ... placeholder) until the caller pins a new date or the user commits a selection through the popup.
applyDefaultDateIfNeeded() now also runs when an explicit null is present, so the popup wheels still open at a sensible default - the UX of "default seeds the popup" stays intact, only the leak into getDate() is closed.
The previously-passing setDateNullReEnablesDefault test codified the buggy behavior; replaced with two tests covering the original report (fresh picker + setDefaultDate + setDate(null)) and the prior-pinned-date variant. The cancelOnFirstOpenKeepsPlaceholderAndDoesNotPinValue (Picker: default value is incorrectly set as new value when user taps Cancel (only on first use) #5014) test now asserts getDate() returns null after Cancel - same invariant ("staged default did not leak"), expressed in terms of the new semantics.

Test plan

mvn -pl core-unittests test -Punittests -DunitTests -Dtest='PickerDefaultDateTest' - 12/12 pass, including the two new regression tests.
mvn -pl core-unittests test -Punittests -DunitTests -Dtest='Picker*' - 31/31 pass across all Picker test classes.
Manually exercise the exact snippet from Picker: doing a setDate(null) then getDate() will return the default value even though the Picker has not been opened and the default value not accepted by the user with Done #5024 in the simulator and confirm "Print Picker GetDate()" prints null before the picker has been opened.

🤖 Generated with Claude Code

setDate(null) previously left dateValueExplicitlySet=false, so a subsequent getDate() on a Picker with setDefaultDate(...) installed silently returned the default getter's result - making getDate() report a date the user had never seen or accepted. Mark the value as explicitly set even for null, so getDate() returns null until the caller pins a new date or the user commits one through the popup. The default getter still primes the popup wheels on the next open via applyDefaultDateIfNeeded (now also triggered when an explicit value of null is present), so the UI keeps a sensible starting point. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

github-actions · 2026-05-24T02:14:37Z

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 2599 total, 0 failed, 0 skipped
📊 Line coverage: 53.92% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.nfc.NdefMessage – 0.00%
  - com.codename1.nfc.NdefRecord – 0.00%
  - com.codename1.components.OtpField – 0.00%
  - com.codename1.nfc.NfcReadOptions – 0.00%
  - com.codename1.nfc.Tag – 0.00%
  - com.codename1.security.AuthenticationOptions – 0.00%
  - com.codename1.nfc.Nfc – 0.00%
  - com.codename1.nfc.ApduResponse – 0.00%
  - com.codename1.system.SimulatorHookExecutor – 0.00%
  - com.codename1.nfc.MifareClassic – 0.00%

Static Analysis

SpotBugs [Report archive]
- ✅ ByteCodeTranslator: 0 findings (no issues)
- ✅ android: 0 findings (no issues)
- ✅ codenameone-maven-plugin: 0 findings (no issues)
- ✅ core-unittests: 0 findings (no issues)
- ✅ ios: 0 findings (no issues)
✅ PMD: 0 findings (no issues) [Report archive]
✅ Checkstyle: 0 findings (no issues) [Report archive]

Generated automatically by the PR CI workflow.

shai-almog · 2026-05-24T02:32:27Z

Compared 110 screenshots: 110 matched.
✅ Native iOS Metal screenshot tests passed.

Benchmark Results

VM Translation Time: 0 seconds
Compilation Time: 348 seconds

Build and Run Timing

Metric	Duration
Simulator Boot	81000 ms
Simulator Boot (Run)	2000 ms
App Install	15000 ms
App Launch	20000 ms
Test Execution	269000 ms

Detailed Performance Metrics

Metric	Duration
Base64 payload size	8192 bytes
Base64 benchmark iterations	6000
Base64 native encode	486.000 ms
Base64 CN1 encode	1419.000 ms
Base64 encode ratio (CN1/native)	2.920x (192.0% slower)
Base64 native decode	269.000 ms
Base64 CN1 decode	885.000 ms
Base64 decode ratio (CN1/native)	3.290x (229.0% slower)
Base64 SIMD encode	400.000 ms
Base64 encode ratio (SIMD/native)	0.823x (17.7% faster)
Base64 encode ratio (SIMD/CN1)	0.282x (71.8% faster)
Base64 SIMD decode	386.000 ms
Base64 decode ratio (SIMD/native)	1.435x (43.5% slower)
Base64 decode ratio (SIMD/CN1)	0.436x (56.4% faster)
Image encode benchmark iterations	100
Image createMask (SIMD off)	55.000 ms
Image createMask (SIMD on)	9.000 ms
Image createMask ratio (SIMD on/off)	0.164x (83.6% faster)
Image applyMask (SIMD off)	128.000 ms
Image applyMask (SIMD on)	52.000 ms
Image applyMask ratio (SIMD on/off)	0.406x (59.4% faster)
Image modifyAlpha (SIMD off)	115.000 ms
Image modifyAlpha (SIMD on)	54.000 ms
Image modifyAlpha ratio (SIMD on/off)	0.470x (53.0% faster)
Image modifyAlpha removeColor (SIMD off)	177.000 ms
Image modifyAlpha removeColor (SIMD on)	117.000 ms
Image modifyAlpha removeColor ratio (SIMD on/off)	0.661x (33.9% faster)
Image PNG encode (SIMD off)	2339.000 ms
Image PNG encode (SIMD on)	958.000 ms
Image PNG encode ratio (SIMD on/off)	0.410x (59.0% faster)
Image JPEG encode	455.000 ms

shai-almog · 2026-05-24T02:33:33Z

Compared 110 screenshots: 110 matched.

Native Android coverage

📊 Line coverage: 11.95% (6793/56827 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 9.70% (34129/351812), branch 4.19% (1399/33371), complexity 5.24% (1677/32020), method 9.09% (1361/14980), class 14.77% (303/2052)
- Lowest covered classes
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
  - kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
  - kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
  - kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/730 lines covered)
  - kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
  - kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

📊 Line coverage: 11.95% (6793/56827 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 9.70% (34129/351812), branch 4.19% (1399/33371), complexity 5.24% (1677/32020), method 9.09% (1361/14980), class 14.77% (303/2052)
- Lowest covered classes
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
  - kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
  - kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
  - kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/730 lines covered)
  - kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
  - kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

Benchmark Results

Detailed Performance Metrics

Metric	Duration
Base64 payload size	8192 bytes
Base64 benchmark iterations	6000
Base64 native encode	793.000 ms
Base64 CN1 encode	195.000 ms
Base64 encode ratio (CN1/native)	0.246x (75.4% faster)
Base64 native decode	680.000 ms
Base64 CN1 decode	271.000 ms
Base64 decode ratio (CN1/native)	0.399x (60.1% faster)
Image encode benchmark status	skipped (SIMD unsupported)

shai-almog · 2026-05-24T02:45:35Z

Compared 110 screenshots: 110 matched.
✅ Native iOS screenshot tests passed.

Benchmark Results

VM Translation Time: 0 seconds
Compilation Time: 200 seconds

Build and Run Timing

Metric	Duration
Simulator Boot	71000 ms
Simulator Boot (Run)	1000 ms
App Install	11000 ms
App Launch	9000 ms
Test Execution	328000 ms

Detailed Performance Metrics

Metric	Duration
Base64 payload size	8192 bytes
Base64 benchmark iterations	6000
Base64 native encode	884.000 ms
Base64 CN1 encode	1382.000 ms
Base64 encode ratio (CN1/native)	1.563x (56.3% slower)
Base64 native decode	321.000 ms
Base64 CN1 decode	945.000 ms
Base64 decode ratio (CN1/native)	2.944x (194.4% slower)
Base64 SIMD encode	623.000 ms
Base64 encode ratio (SIMD/native)	0.705x (29.5% faster)
Base64 encode ratio (SIMD/CN1)	0.451x (54.9% faster)
Base64 SIMD decode	462.000 ms
Base64 decode ratio (SIMD/native)	1.439x (43.9% slower)
Base64 decode ratio (SIMD/CN1)	0.489x (51.1% faster)
Image encode benchmark iterations	100
Image createMask (SIMD off)	63.000 ms
Image createMask (SIMD on)	14.000 ms
Image createMask ratio (SIMD on/off)	0.222x (77.8% faster)
Image applyMask (SIMD off)	192.000 ms
Image applyMask (SIMD on)	114.000 ms
Image applyMask ratio (SIMD on/off)	0.594x (40.6% faster)
Image modifyAlpha (SIMD off)	120.000 ms
Image modifyAlpha (SIMD on)	59.000 ms
Image modifyAlpha ratio (SIMD on/off)	0.492x (50.8% faster)
Image modifyAlpha removeColor (SIMD off)	146.000 ms
Image modifyAlpha removeColor (SIMD on)	63.000 ms
Image modifyAlpha removeColor ratio (SIMD on/off)	0.432x (56.8% faster)
Image PNG encode (SIMD off)	1150.000 ms
Image PNG encode (SIMD on)	1170.000 ms
Image PNG encode ratio (SIMD on/off)	1.017x (1.7% slower)
Image JPEG encode	745.000 ms

shai-almog merged commit b66ff9e into master May 24, 2026
19 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #5024: treat Picker.setDate(null) as an explicit clear#5025

Fix #5024: treat Picker.setDate(null) as an explicit clear#5025
shai-almog merged 1 commit into
masterfrom
fix-5024-picker-setdate-null-explicit-clear

shai-almog commented May 24, 2026

Uh oh!

github-actions Bot commented May 24, 2026

Uh oh!

shai-almog commented May 24, 2026 •

edited

Loading

Uh oh!

shai-almog commented May 24, 2026 •

edited

Loading

Uh oh!

shai-almog commented May 24, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

shai-almog commented May 24, 2026

Summary

Test plan

Uh oh!

github-actions Bot commented May 24, 2026

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Uh oh!

shai-almog commented May 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmark Results

Build and Run Timing

Detailed Performance Metrics

Uh oh!

shai-almog commented May 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Native Android coverage

Native Android coverage

Benchmark Results

Detailed Performance Metrics

Uh oh!

shai-almog commented May 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmark Results

Build and Run Timing

Detailed Performance Metrics

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

shai-almog commented May 24, 2026 •

edited

Loading

shai-almog commented May 24, 2026 •

edited

Loading

shai-almog commented May 24, 2026 •

edited

Loading