Generate JavaSE desktop stub from codenameone_settings.properties#5043
Merged
Conversation
Initializr-generated projects ship only the Lifecycle subclass and no <MainName>Stub.java, so `mvn verify -P run-desktop` failed with ClassNotFoundException. The stub carries app-specific configuration (title, dimensions, fullscreen flag, etc.) and should be emitted by the plugin from settings/build-hints rather than shipped statically, the way the iOS and Android builders already do. GenerateDesktopAppWrapperMojo now writes target/generated-sources/cn1-desktop/<pkg>/<MainName>Stub.java from a packaged template, substituting codename1.mainName / packageName / displayName / version and the codename1.arg.desktop.* build hints (title, width, height, fullscreen, resizable, adaptToRetina), and adds the directory as a compile source root. A hand-rolled src/desktop/java/<pkg>/<MainName>Stub.java still wins so apps can take full control when the hint surface is not enough. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Compared 20 screenshots: 20 matched. |
Contributor
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
Collaborator
Author
|
Compared 110 screenshots: 110 matched. Native Android coverage
✅ Native Android screenshot tests passed. Native Android coverage
Benchmark ResultsDetailed Performance Metrics
|
Collaborator
Author
|
Compared 109 screenshots: 109 matched. Benchmark Results
Build and Run Timing
Detailed Performance Metrics
|
Collaborator
Author
|
Compared 110 screenshots: 110 matched. Benchmark Results
Build and Run Timing
Detailed Performance Metrics
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lifecyclesubclass and no<MainName>Stub.java, somvn verify -P run-desktopfailed withClassNotFoundException. The stub carries app-specific configuration (title, dimensions, fullscreen flag, etc.) and should be emitted by the plugin from settings/build-hints, the wayIPhoneBuilderandAndroidGradleBuilderalready do for their targets.GenerateDesktopAppWrapperMojonow writestarget/generated-sources/cn1-desktop/<pkg>/<MainName>Stub.javafrom a packaged template, substitutingcodename1.mainName/packageName/displayName/versionand thecodename1.arg.desktop.*build hints (title,width,height,fullscreen,resizable,adaptToRetina), and adds the directory as a compile source root.javase/src/desktop/java/<pkg>/<MainName>Stub.javastill wins so apps can fully customize when the hint surface is not enough.Test plan
mvn installinmaven/codenameone-maven-plugin).MyAppName extends Lifecycle, no Stub on disk) succeeds withmvn verify -P run-desktop: stub is generated, compiled, andexec:javabootsJavaSEPortinstead of failing withClassNotFoundException.MyAppNameStub.javaunderjavase/src/desktop/java/com/example/myapp/causes the mojo to logCustom desktop stub found ... - skipping generationand use the user file.desktop.framePrepare/desktop.frameShowbody-injection hints; wiredesktop.fontFacesto a comma-separated build hint.🤖 Generated with Claude Code