scripts/initializr: sync template with cn1app-archetype#5093
Merged
Conversation
The initializr-served project template drifted from the
cn1app-archetype:
- common/pom.xml and javase/pom.xml both lacked the
org.junit.jupiter:junit-jupiter:5.9.3 test-scope dependency, so the
JUnit 5 test that ships in common/src/test/java fails to compile
("package org.junit.jupiter.api does not exist") in any generated
project.
- common/pom.xml was missing the codenameone-maven-plugin
transcode-svg execution and the process-annotations goal on
cn1-process-classes, so generated apps had no SVG transcoding and
no @route dispatcher generation.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Cloudflare Preview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The initializr-served project template had drifted from
maven/cn1app-archetype/src/main/resources/archetype-resources/, leaving freshly generated projects in a broken state for tests and missing two CN1 plugin features.common/pom.xmlandjavase/pom.xmlwere missing theorg.junit.jupiter:junit-jupiter:5.9.3test-scope dep. Because the generated sample test (common/src/test/java/.../GreetingFormTest.java) importsorg.junit.jupiter.api.Test,mvn testfrom a freshly generated project fails attestCompileincommonwithpackage org.junit.jupiter.api does not exist.common/pom.xmlwas missing thecodenameone-maven-plugintranscode-svgexecution (build-time SVG →GeneratedSVGImagetranscoder) and theprocess-annotationsgoal on thecn1-process-classesexecution (@Routedispatcher generation). Both are present in the archetype.This brings the initializr template in line with the archetype on those points.
Test plan
common/src/test/javaJUnit 5 sample compiles and the IDE gutter run-arrow onGreetingFormTestresolves all imports.common/src/main/svg/and confirm aGeneratedSVGImagesubclass is produced duringprocess-sources.@Routeand confirm the dispatcher class is generated duringprocess-classes.🤖 Generated with Claude Code