Seed missing Android golden for DesktopModeScreenshotTest#5178
Closed
shai-almog wants to merge 1 commit into
Closed
Seed missing Android golden for DesktopModeScreenshotTest#5178shai-almog wants to merge 1 commit into
shai-almog wants to merge 1 commit into
Conversation
DesktopModeScreenshotTest was added in #5170 ("Deepen desktop integration") but no reference screenshots were committed, so every CI screenshot run reports DesktopMode as "missing reference" (non-fatal, but it means the test has no baseline). This seeds the Android baseline from the full-resolution emulator render produced by the scripts-android CI job, so the Android instrumentation screenshot suite now has a golden to compare against. The captured screen is the desktop-mode list (title bar + colored rows), 320x640, matching the other Android goldens. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Compared 124 screenshots: 124 matched. Native Android coverage
✅ Native Android screenshot tests passed. Native Android coverage
Benchmark ResultsDetailed Performance Metrics
|
Collaborator
Author
|
Folded into #5177 (everything consolidated into the camera PR per request); closing this standalone PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Seeds the missing Android reference screenshot for
DesktopModeScreenshotTest.DesktopModeScreenshotTestwas added in #5170 ("Deepen desktop integration") but no baselines were ever committed, so every screenshot run reportsDesktopModeas missing reference on all platforms (see the CI comments on #5177). On Android this is non-fatal, but it means the test has no golden to compare against.This commits the Android baseline harvested from the full-resolution emulator render produced by the
scripts-androidCI job (320×640, matching the other Android goldens):≡ Desktop Mode+ colored list rows (Row 1…N)How it was produced
Downloaded the full-res
DesktopMode.pngfrom theemulator-screenshotartifact of a passingscripts-androidrun, rather than rendering locally (the comparison tolerance is 0.30% / channel-delta 4, so a non-CI render wouldn't match).Scope / follow-ups
DesktopModeis also missing onios,mac-native, andjavascript— happy to seed those too in a follow-up.ChatView_*andToolbarTheme_*differing (not missing) — that looks like native-theme drift from the Regenerate native theme .res files for #5170 CSS changes #5174.resregeneration and is unrelated to this golden; flagging it for a separate decision.🤖 Generated with Claude Code