MacNativeBuilder: optional Developer ID signing + notarization#5243
Merged
Conversation
Adds opt-in (macNative.notarize=true) Developer ID signing with the hardened runtime, notarization (notarytool --wait) and stapling, so a pre-compiled Mac-native app clears Gatekeeper when downloaded instead of relying on the ad-hoc/linker signature a quarantined download cannot use. The Developer ID cert is supplied the same way as the iOS build (the request certificate/.p12 + password), imported into a throwaway keychain so the build host needs nothing pre-installed. Notary credentials via macNative.notarize.keychainProfile or appleId/teamId/password. Default off, so existing builds are unchanged; signs with the *-DeveloperID.entitlements the builder already generates. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
Author
|
Compared 128 screenshots: 128 matched. Native Android coverage
✅ Native Android screenshot tests passed. Native Android coverage
Benchmark ResultsDetailed Performance Metrics
|
Contributor
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
Collaborator
Author
|
Compared 128 screenshots: 128 matched. Benchmark Results
Detailed Performance Metrics
|
Collaborator
Author
|
Compared 121 screenshots: 121 matched. |
Collaborator
Author
|
Compared 124 screenshots: 124 matched. Benchmark Results
Build and Run Timing
Detailed Performance Metrics
|
Collaborator
Author
|
Compared 128 screenshots: 128 matched. Benchmark Results
Build and Run Timing
Detailed Performance Metrics
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds opt-in Developer ID signing + notarization to
MacNativeBuilderso a pre-compiled Mac-native app clears Gatekeeper when downloaded, rather than relying on the ad-hoc/linker signature that a quarantined download cannot use.Gated on
macNative.notarize=true(default off — existing builds are unchanged).How
signAndNotarizeMacApp(request, appBundle, developerIdEntitlements):request.getCertificate()/getCertificatePassword()), so the build host needs nothing pre-installed.--options runtime+ the*-DeveloperID.entitlementsthe builder already generates.xcrun notarytool submit --wait,xcrun stapler staple, then verifies.Notary credentials via
macNative.notarize.keychainProfileormacNative.notarize.appleId/teamId/password.Called by whatever produces the Mac
.app(the release pipeline afterxcodebuild).🤖 Generated with Claude Code