Initializr: fix white box behind generate-button icon; shift button clear of Crisp launcher#5302
Merged
Conversation
…lear of Crisp launcher The "Generate Project" button set its download icon before applying the InitializrPrimaryButton UIID. FontImage.create bakes the component's current background into the glyph image, so the icon captured the default Button style's opaque white background and painted a white box behind the glyph. Derive the icon after setUIID so it captures the lime primary-button background (matching the pill-dot order elsewhere in the file). The button also sat under the host page's Crisp chat launcher (bottom-right). Extend the existing website theme-sync native bridge with chatLauncherClearance(): the JS impl reports the launcher footprint in CSS pixels when a visible .crisp-client is present (0 when hidden/declined), and the initializr poll adds that as a right margin so the button slides left, clear of the bubble. The JS port works in CSS pixels, so the value maps 1:1. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Cloudflare Preview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two issues on the start.codenameone.com Initializr "Generate Project" button:
InitializrPrimaryButtonUIID was applied.FontImage.create()bakes the component's current background into the glyph image (FontImage.java:7643-7644, painted at:7781), so it captured the defaultButtonstyle's opaque white background and drew a white box behind the glyph.Fix
Icon — derive the icon after
setUIID(...)so it captures the lime primary-button background. This matches the existing order used for the hero pill dot (Initializr.java:251-252); the generate button was the lone anomaly. The icon box now blends into the button instead of showing white.Crisp shift — reuse the existing website↔iframe native bridge (which already polls dark-mode every 900ms):
WebsiteThemeNative.chatLauncherClearance()— new method returning the horizontal clearance (CSS px) the Crisp launcher needs,0when hidden. The JS impl reports96when a visible.crisp-clientexists in the parent document (the launcher's standard footprint),0when it is hidden or consent was declined. The javase/android impls return0.Initializr.applyChatLauncherClearance()— applies that as a right margin on the button so it slides left, clear of the bubble. The JS port works in CSS pixels (overridePixelRatio = 1), so the reported value maps 1:1. It only relayouts on change, andapplyDarkModeresets the cache so a theme refresh re-applies the margin.Verification
commonsource tree + the javase impl (against the fresh interface) + the android impl with JDK 8 against the8.0-SNAPSHOTcore — no errors.node --checkpasses on the JS native.callback.complete(<number>)int-return convention confirmed against the existingStatusBarTapDiagnosticNative.js:10precedent.Note: I did not run the full ParparVM JS site build (heavy). The 96px clearance is a bounded constant sized to Crisp's default launcher; happy to tune it after an in-browser build if desired.
🤖 Generated with Claude Code