Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPORTANT:- Note that in the implementation I have committed I have taken the MKFS from the C directory only so my makefile assumes MKFS to be already present in a specified folder. This was done as I didn't have the code for MKFS in rust. Once that code is added we can change the mkfs dependency in the Makefile.
I have implemented the redo logging functionality analogous to the one done in the C code although the file layer is not yet added. I built it on the write commit which I made
src/log.rsimplementing:initlog(dev)begin_op()end_op()log_write(buf_idx)read_head()write_head()write_log()install_trans()recover_from_log()commit()Behavior matches the simple single-transaction model:
begin_op()is a no-opend_op()commits immediatelysrc/param.rs:MAXOPBLOCKSLOGSIZE = MAXOPBLOCKS * 3Updated
src/fs.rsso mutating operations uselog_write()instead of directbwrite():bzero,balloc)ialloc,iupdate)bmapwriteiThis ensures modified blocks are tracked in the transaction and written through the log commit path.
src/lib.rs:log::initlog(ROOTDEV)afteriinit(ROOTDEV)welcome()withbegin_op()/end_op()Validation
make xv6.img fs.imgsucceedsmake qemuboots and runs correctly