This repository was archived by the owner on Apr 13, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 26
Samples/midi output send random values #110
Merged
hlxid
merged 17 commits into
codeoverflow-org:master
from
NeoCortex97:samples/midi-output-send-random-values
Sep 14, 2020
Merged
Samples/midi output send random values #110
hlxid
merged 17 commits into
codeoverflow-org:master
from
NeoCortex97:samples/midi-output-send-random-values
Sep 14, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Schmelz/nodecg-io into samples/midi-input-display-values
hlxid
reviewed
Sep 14, 2020
Member
hlxid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine, only a couple nitpicks 😉.
Can you please re-add the /package-lock.json from the repository root?
Co-authored-by: Daniel Huber <daniel.hub@outlook.de>
…tefanSchmelz/nodecg-io into samples/midi-output-send-random-values
hlxid
approved these changes
Sep 14, 2020
Member
hlxid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @StefanSchmelz
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Written a ample for midi output that sends note on messages every second