fix: tolerate codex rollout recorder stderr#86
Closed
SamuelLHuber wants to merge 1 commit intocodeplaneapp:mainfrom
Closed
fix: tolerate codex rollout recorder stderr#86SamuelLHuber wants to merge 1 commit intocodeplaneapp:mainfrom
SamuelLHuber wants to merge 1 commit intocodeplaneapp:mainfrom
Conversation
Problem: Codex can exit non-zero with only rollout recorder shutdown noise, which Smithers treated as fatal. Fix: filter known rollout-recorder and cache TTL stderr lines; treat Codex non-zero as success when stderr is empty after filtering. Assumptions: rollout-recorder and cache TTL errors are non-fatal if output schema is still produced.
Contributor
|
Reading this late at night and I'm sick. My brain wasn't able to download what this pr is doing right away will circle back tomorrow or monday |
roninjin10
added a commit
that referenced
this pull request
Mar 18, 2026
Rebased from SamuelLHuber/fix/codex-rollout-recorder (PR #86) onto refactored codebase. Original file src/agents/cli.ts was split into individual agent files; changes applied to src/agents/BaseCliAgent.ts. Adds three new benign stderr patterns for codex rollout recorder shutdown noise and cache TTL errors. When codex exits non-zero but stderr is empty after filtering, treat it as success. Also regenerates docs/llms-full.txt to fix docs sync test. Co-Authored-By: Samuel Huber <samuel@dtech.vision> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Superseded — rebased onto current main in fix/codex-rollout-recorder (original file was split in the agents refactor). Thank you @SamuelLHuber! |
roninjin10
added a commit
that referenced
this pull request
Mar 18, 2026
Rebased from SamuelLHuber/fix/codex-rollout-recorder (PR #86) onto refactored codebase. Original file src/agents/cli.ts was split into individual agent files; changes applied to src/agents/BaseCliAgent.ts. Adds three new benign stderr patterns for codex rollout recorder shutdown noise and cache TTL errors. When codex exits non-zero but stderr is empty after filtering, treat it as success. Also regenerates docs/llms-full.txt to fix docs sync test. Co-authored-by: Samuel Huber <samuel@dtech.vision> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is something that just came up today for me, so not sure if others have the same issues. this local fix worked for me.
Problem: Codex can exit non-zero with only rollout recorder shutdown noise, which Smithers treated as fatal.
Fix: filter known rollout-recorder and cache TTL stderr lines; treat Codex non-zero as success when stderr is empty after filtering.
Assumptions: rollout-recorder and cache TTL errors are non-fatal if output schema is still produced.