Feature/workups #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 2, 2015 12:54
If not published, it can still be included via git. ~~~ "BigRedButtonNodeHID": "git+ssh://git@github.com:codepope/BigRedButtonNodeHID.git#1.0.0" ~~~
Author
There was a problem hiding this comment.
This didn't show up in my cases before as it's a race condition to see if write or read gets called first. So this never happened but did later.
Author
|
Also fixes #5 |
codepope
added a commit
that referenced
this pull request
Jan 3, 2015
Feature/workups - Bring in for cleanup
Owner
|
Pulled in... but going to run through and test new code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even without a
npm publishthis will fix #1 since it can still be included in projects.